From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1YTb-0002Gr-VI for qemu-devel@nongnu.org; Tue, 01 Nov 2016 08:47:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1YTb-0002m6-6v for qemu-devel@nongnu.org; Tue, 01 Nov 2016 08:47:39 -0400 Received: from mail-ua0-x22f.google.com ([2607:f8b0:400c:c08::22f]:34760) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1YTa-0002lb-Qf for qemu-devel@nongnu.org; Tue, 01 Nov 2016 08:47:39 -0400 Received: by mail-ua0-x22f.google.com with SMTP id 51so109712850uai.1 for ; Tue, 01 Nov 2016 05:47:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20161101004526-mutt-send-email-mst@kernel.org> References: <1477850917-1214-1-git-send-email-mst@redhat.com> <20161031105031.2ea5061d@nial.brq.redhat.com> <20161101004526-mutt-send-email-mst@kernel.org> From: Peter Maydell Date: Tue, 1 Nov 2016 12:47:15 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL 00/47] virtio, pc: fixes and features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Igor Mammedov , QEMU Developers On 31 October 2016 at 22:48, Michael S. Tsirkin wrote: > On Mon, Oct 31, 2016 at 10:50:31AM +0100, Igor Mammedov wrote: >> On Sun, 30 Oct 2016 23:23:18 +0200 >> "Michael S. Tsirkin" wrote: >> >> > The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: >> > >> > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into staging (2016-10-28 17:59:04 +0100) >> > >> > are available in the git repository at: >> > >> > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream >> > >> > for you to fetch changes up to f082ec0225bd15c71e0b4697d2df3af7bad65d7f: >> > >> > acpi: fix assert failure caused by commit 35c5a52d (2016-10-30 20:06:25 +0200) >> > >> > ---------------------------------------------------------------- >> > virtio, pc: fixes and features >> > >> > nvdimm hotplug support >> Michael, >> >> Could you drop nvdimm hotplug from pull request (I should review at least once as it touches not only NVDIMMs but a generic hotplug infrastructure) >> >> and keep only nvdimm fixes/cleanups for now? > > If I drop it now it won't be in the next QEMU and it seems like > a valuable feature. The comments so far are about minor style > improvements that IMO can be addressed by patches on top. > > We can always revert if you see bigger issues, but let's enable the > testing of this feature. I'm waiting for a reply from Igor before I do anything with this pull request. thanks -- PMM