From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0509AC432C0 for ; Mon, 2 Dec 2019 18:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC54720718 for ; Mon, 2 Dec 2019 18:27:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zXaEndRp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbfLBS1w (ORCPT ); Mon, 2 Dec 2019 13:27:52 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:39555 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727721AbfLBS1w (ORCPT ); Mon, 2 Dec 2019 13:27:52 -0500 Received: by mail-oi1-f195.google.com with SMTP id a67so585083oib.6 for ; Mon, 02 Dec 2019 10:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dP2JCQbWzYq+j6H+K0zSpsgH9pH8Yu2DiLKkze34i5c=; b=zXaEndRpo940BmNkNAkaG6vBp7FBhL5TWuQQlK2FC9TCYW/TZ0ynoQO+5wlTMTzXn6 bG4GbRuqtTqouOX40iBFMVnXfO7I/1g48C+2ag5kOYw4IG0s7mmbfrrWVZ5CJsfa+zqc Mdey985FaDxiu07xmI2G1Gz+8whe2ARv9+Qv7mdRxmcxEZiL6EbJ5QDPt/Pytv3f6bnD B2pJibyJzHzPvCnBY2/X9aKraz+F6iixJVPkEihesTLkgOydvd6ISSTReRoaPcfd22Vb CU1XSDlQefGLowhufDortNYAg872s+1ka5doOtHs4UVwWOu1s8f1EXdIgUK+/LOoKDHd Qsmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dP2JCQbWzYq+j6H+K0zSpsgH9pH8Yu2DiLKkze34i5c=; b=j2kEzs0CeqJpgFAe+CrSm9GwlDmVfuaq/lsRTVqdW5W9qrjuEi5QAGknToxsEzILqM ltaZb+ETH0d1JaTUXtFdybmTZbgCot8l6zvMOa7zSMoaeh96rdbGP0oikOWWD/g7tbXQ 05v2TWy1UtZI5EeCV8F7+NCqyVeddNKsvY5Uaf1GeWkdgMX/WtTBE2bBrNqU1+GLooVD F3yBpRPjAs6QOPY5rmXyiRlNAmNOkZGBNdDWWfQj2Hw+Ur4iz4JA+HCU/6Ax25MGdkMX 43BDJLNVBdMOjrqcM9k3PPN/pAmbU41GhshZeD45yD0othq+XGpwhazbLRQYjgUrX8As HtCA== X-Gm-Message-State: APjAAAVhm2ZFjMkLps/ODD4N5SE1cxv7hw9fYYam1eEkFbVmA2B8W2Yl CquxEPxbLWqwPzZaBxlkbgTv4B0GGH90rs7pH/VXuA== X-Google-Smtp-Source: APXvYqzYkcr1K/kbJ9V5EeCHx+PRqgxp8GQzi/6Rw2Jb5q31RVmSbaRKDgbS1Q2W2/t69lWVMT1IcbklCE2EXW5NnY0= X-Received: by 2002:aca:edd5:: with SMTP id l204mr369787oih.98.1575311271706; Mon, 02 Dec 2019 10:27:51 -0800 (PST) MIME-Version: 1.0 References: <20191111014048.21296-1-zhengxiang9@huawei.com> In-Reply-To: <20191111014048.21296-1-zhengxiang9@huawei.com> From: Peter Maydell Date: Mon, 2 Dec 2019 18:27:40 +0000 Message-ID: Subject: Re: [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU To: Xiang Zheng Cc: Paolo Bonzini , "Michael S. Tsirkin" , Igor Mammedov , Shannon Zhao , Laszlo Ersek , James Morse , gengdongjiu , Marcelo Tosatti , Richard Henderson , Eduardo Habkost , Jonathan Cameron , "xuwei (O)" , kvm-devel , QEMU Developers , qemu-arm , Linuxarm , wanghaibin.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, 11 Nov 2019 at 01:44, Xiang Zheng wrote: > > In the ARMv8 platform, the CPU error types are synchronous external abort(SEA) > and SError Interrupt (SEI). If exception happens in guest, sometimes it's better > for guest to perform the recovery, because host does not know the detailed > information of guest. For example, if an exception happens in a user-space > application within guest, host does not know which application encounters > errors. > > For the ARMv8 SEA/SEI, KVM or host kernel delivers SIGBUS to notify userspace. > After user space gets the notification, it will record the CPER into guest GHES > buffer and inject an exception or IRQ into guest. > > In the current implementation, if the type of SIGBUS is BUS_MCEERR_AR, we will > treat it as a synchronous exception, and notify guest with ARMv8 SEA > notification type after recording CPER into guest. Hi; I've given you reviewed-by tags on a couple of patches; other people have given review comments on some of the other patches, so I think you have enough to do a v22 addressing those. thanks -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D6BC432C0 for ; Mon, 2 Dec 2019 18:28:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E62C20718 for ; Mon, 2 Dec 2019 18:28:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zXaEndRp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E62C20718 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibqR6-0006aQ-O0 for qemu-devel@archiver.kernel.org; Mon, 02 Dec 2019 13:28:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60761) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibqQL-0005qM-KC for qemu-devel@nongnu.org; Mon, 02 Dec 2019 13:27:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibqQK-0004YJ-Ho for qemu-devel@nongnu.org; Mon, 02 Dec 2019 13:27:53 -0500 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:46862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibqQK-0004Xo-Cy for qemu-devel@nongnu.org; Mon, 02 Dec 2019 13:27:52 -0500 Received: by mail-oi1-x244.google.com with SMTP id a124so532751oii.13 for ; Mon, 02 Dec 2019 10:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dP2JCQbWzYq+j6H+K0zSpsgH9pH8Yu2DiLKkze34i5c=; b=zXaEndRpo940BmNkNAkaG6vBp7FBhL5TWuQQlK2FC9TCYW/TZ0ynoQO+5wlTMTzXn6 bG4GbRuqtTqouOX40iBFMVnXfO7I/1g48C+2ag5kOYw4IG0s7mmbfrrWVZ5CJsfa+zqc Mdey985FaDxiu07xmI2G1Gz+8whe2ARv9+Qv7mdRxmcxEZiL6EbJ5QDPt/Pytv3f6bnD B2pJibyJzHzPvCnBY2/X9aKraz+F6iixJVPkEihesTLkgOydvd6ISSTReRoaPcfd22Vb CU1XSDlQefGLowhufDortNYAg872s+1ka5doOtHs4UVwWOu1s8f1EXdIgUK+/LOoKDHd Qsmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dP2JCQbWzYq+j6H+K0zSpsgH9pH8Yu2DiLKkze34i5c=; b=BGKZ6Fc1rJjco60a3gVdrgRcOVHJvt602T9tCpcOyJSAXIp0sMyq/6Qk0BMHsZbdHq fDUhoedwJDkV4PXiTUnwBiIBEaTbDeLdZPZaixVTARsC8grSEyyamNvUkXokMlUmNHTo Hm1dYRV9mRVWNQv6clshhKDEArUN3fpEyQ7Vf+QqCmcqNCK1MsdBhpzB1QlTDZ/8O0Da lKl9oJfAT7+TVj6UJmC+QFTVMdSIWlkq+kJf4uNHCaEARugdO+AWwKqhSRwSsBGlnNjx owW838GLxnzuTfYz+Muw3j4aV165e0EjXX1Dynu5y2dVslIzU6muzr9gQsQXzWZMbk69 iuNg== X-Gm-Message-State: APjAAAU9xVF/Jfce/y1Pu/w8/kZPL3+NzlbRm+wHsnh96iTzLghXb/LK 7FRbPTJgixNnc6NELu/R7WBHzVyIxGFXSjgXea/xCw== X-Google-Smtp-Source: APXvYqzYkcr1K/kbJ9V5EeCHx+PRqgxp8GQzi/6Rw2Jb5q31RVmSbaRKDgbS1Q2W2/t69lWVMT1IcbklCE2EXW5NnY0= X-Received: by 2002:aca:edd5:: with SMTP id l204mr369787oih.98.1575311271706; Mon, 02 Dec 2019 10:27:51 -0800 (PST) MIME-Version: 1.0 References: <20191111014048.21296-1-zhengxiang9@huawei.com> In-Reply-To: <20191111014048.21296-1-zhengxiang9@huawei.com> From: Peter Maydell Date: Mon, 2 Dec 2019 18:27:40 +0000 Message-ID: Subject: Re: [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU To: Xiang Zheng Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , kvm-devel , "Michael S. Tsirkin" , wanghaibin.wang@huawei.com, Marcelo Tosatti , Linuxarm , QEMU Developers , gengdongjiu , Shannon Zhao , qemu-arm , James Morse , Jonathan Cameron , Igor Mammedov , Paolo Bonzini , "xuwei \(O\)" , Laszlo Ersek , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 11 Nov 2019 at 01:44, Xiang Zheng wrote: > > In the ARMv8 platform, the CPU error types are synchronous external abort(SEA) > and SError Interrupt (SEI). If exception happens in guest, sometimes it's better > for guest to perform the recovery, because host does not know the detailed > information of guest. For example, if an exception happens in a user-space > application within guest, host does not know which application encounters > errors. > > For the ARMv8 SEA/SEI, KVM or host kernel delivers SIGBUS to notify userspace. > After user space gets the notification, it will record the CPER into guest GHES > buffer and inject an exception or IRQ into guest. > > In the current implementation, if the type of SIGBUS is BUS_MCEERR_AR, we will > treat it as a synchronous exception, and notify guest with ARMv8 SEA > notification type after recording CPER into guest. Hi; I've given you reviewed-by tags on a couple of patches; other people have given review comments on some of the other patches, so I think you have enough to do a v22 addressing those. thanks -- PMM