From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWnDj-00010X-Qh for qemu-devel@nongnu.org; Wed, 03 Jan 2018 12:52:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWnDj-0004nw-3T for qemu-devel@nongnu.org; Wed, 03 Jan 2018 12:52:55 -0500 Received: from mail-oi0-x236.google.com ([2607:f8b0:4003:c06::236]:40828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eWnDi-0004nD-VG for qemu-devel@nongnu.org; Wed, 03 Jan 2018 12:52:55 -0500 Received: by mail-oi0-x236.google.com with SMTP id w125so1452931oie.7 for ; Wed, 03 Jan 2018 09:52:54 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20171215150659.1811-1-marcandre.lureau@redhat.com> <20171215150659.1811-5-marcandre.lureau@redhat.com> From: Peter Maydell Date: Wed, 3 Jan 2018 17:52:33 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH v2 04/13] build-sys: add AddressSanitizer when --enable-debug if possible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , QEMU , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Fam Zheng On 2 January 2018 at 17:31, Paolo Bonzini wrote: > 2) I think removing -O2 from --enable-debug should be removed at the > same time. That pretty much guarantees that nobody will use > --enable-debug, and optimized builds are decently debuggable nowadays. > The best would be to detect -Og, and add either -Og or -O1 depending on > presence. Hmm. I use --enable-debug all the time and one of the reasons I use it is that the optimized build is usually more pain to debug with... thanks -- PMM