From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49480)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1Wupic-0005nK-8h
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 17:06:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WupiW-0003xw-Lf
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 17:06:02 -0400
Received: from mail-lb0-f174.google.com ([209.85.217.174]:57109)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1WupiW-0003x4-Ec
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 17:05:56 -0400
Received: by mail-lb0-f174.google.com with SMTP id n15so182108lbi.33
	for <qemu-devel@nongnu.org>; Wed, 11 Jun 2014 14:05:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAOgzsHVfpFW6OMmyX75KZw-myFKVLvDezFfqBfDqgsbQac8L9Q@mail.gmail.com>
References: <1402326269-8573-1-git-send-email-edgar.iglesias@gmail.com>
	<1402326269-8573-14-git-send-email-edgar.iglesias@gmail.com>
	<CAOgzsHVfpFW6OMmyX75KZw-myFKVLvDezFfqBfDqgsbQac8L9Q@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Wed, 11 Jun 2014 22:05:35 +0100
Message-ID: <CAFEAcA96xH9HfMZE7q7jtn8a=D2Md20Z+7wmQ7QjqtOEv7RfQA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v2 13/17] target-arm: Use uint16_t in
 syndrome generators with 16bit imms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Bellows <greg.bellows@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Fabian Aggeler <aggelerf@ethz.ch>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, John Williams <john.williams@xilinx.com>, Paolo Bonzini <pbonzini@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On 11 June 2014 20:19, Greg Bellows <greg.bellows@linaro.org> wrote:
> Called out possibly missing fix below.  Beside it, I'm convinced this change
> is beneficial, other than maybe for readability.

"not convinced" ?

Personally, I don't much care either way, but I would suggest that
if you're trying to get a big fat patchset through it's usually better
not to throw in too many not-actually-needed patches :-)

-- PMM