From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Maydell Subject: Re: [PATCH 12/15] qdev: using devtree lock to protect device's accessing Date: Wed, 8 Aug 2012 10:33:39 +0100 Message-ID: References: <1344407156-25562-1-git-send-email-qemulist@gmail.com> <1344407156-25562-13-git-send-email-qemulist@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: kvm@vger.kernel.org, Stefan Hajnoczi , Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Anthony Liguori , Jan Kiszka , Paolo Bonzini , =?UTF-8?Q?Andreas_F=C3=A4rber?= To: Liu Ping Fan Return-path: In-Reply-To: <1344407156-25562-13-git-send-email-qemulist@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 8 August 2012 07:25, Liu Ping Fan wrote: > From: Liu Ping Fan > > lock: > qemu_device_tree_mutex Looking at where it's used, this doesn't seem to have anything to do with device trees (ie dtb, see www.devicetree.org) : poorly named lock? -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz2e8-0000h9-Gy for qemu-devel@nongnu.org; Wed, 08 Aug 2012 05:33:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz2e3-00088a-Ts for qemu-devel@nongnu.org; Wed, 08 Aug 2012 05:33:44 -0400 Received: from mail-gh0-f173.google.com ([209.85.160.173]:43395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz2e3-00088W-Om for qemu-devel@nongnu.org; Wed, 08 Aug 2012 05:33:39 -0400 Received: by ghrr17 with SMTP id r17so525765ghr.4 for ; Wed, 08 Aug 2012 02:33:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1344407156-25562-13-git-send-email-qemulist@gmail.com> References: <1344407156-25562-1-git-send-email-qemulist@gmail.com> <1344407156-25562-13-git-send-email-qemulist@gmail.com> Date: Wed, 8 Aug 2012 10:33:39 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 12/15] qdev: using devtree lock to protect device's accessing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Ping Fan Cc: kvm@vger.kernel.org, Stefan Hajnoczi , Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Anthony Liguori , Jan Kiszka , Paolo Bonzini , =?UTF-8?Q?Andreas_F=C3=A4rber?= On 8 August 2012 07:25, Liu Ping Fan wrote: > From: Liu Ping Fan > > lock: > qemu_device_tree_mutex Looking at where it's used, this doesn't seem to have anything to do with device trees (ie dtb, see www.devicetree.org) : poorly named lock? -- PMM