Re: [Qemu-devel] [PATCH v3 15/16] tci: Define TCG_TARGET_INSN_UNIT_SIZE

From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: Stefan Weil <sw@weilnetz.de>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 15/16] tci: Define TCG_TARGET_INSN_UNIT_SIZE
Date: Fri, 9 May 2014 14:52:52 +0100	[thread overview]
Message-ID: <CAFEAcA98xoR-41qSeEqN4AUHGKRvRotvjyQtppiuaMNGSwzmQg@mail.gmail.com> (raw)
In-Reply-To: <1398713302-29657-16-git-send-email-rth@twiddle.net>

On 28 April 2014 20:28, Richard Henderson <rth@twiddle.net> wrote:
> And use tcg pointer differencing functions as appropriate.
>
> Cc: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/tci/tcg-target.c | 19 +++++++++++++------
>  tcg/tci/tcg-target.h |  1 +
>  2 files changed, 14 insertions(+), 6 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

though I note there are a number of functions that
use the pattern

    uint8_t *old_code_ptr = s->code_ptr;
    [...emit stuff...]
    old_code_ptr[1] = s->code_ptr - old_code_ptr;

which could perhaps use tcg_insn_unit * rather than uint8_t * ?

thanks
-- PMM