From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YIisV-0000pi-0b
	for qemu-devel@nongnu.org; Tue, 03 Feb 2015 14:11:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YIisQ-0006Pd-Ia
	for qemu-devel@nongnu.org; Tue, 03 Feb 2015 14:11:14 -0500
Received: from mail-lb0-f179.google.com ([209.85.217.179]:43316)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YIisQ-0006PX-B7
	for qemu-devel@nongnu.org; Tue, 03 Feb 2015 14:11:10 -0500
Received: by mail-lb0-f179.google.com with SMTP id 10so40380177lbg.10
	for <qemu-devel@nongnu.org>; Tue, 03 Feb 2015 11:11:09 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1422403117-16921-3-git-send-email-greg.bellows@linaro.org>
References: <1422403117-16921-1-git-send-email-greg.bellows@linaro.org>
	<1422403117-16921-3-git-send-email-greg.bellows@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 3 Feb 2015 19:10:49 +0000
Message-ID: <CAFEAcA9B+WMLVSJbiv+wTOQO9-XCJejHe4T1VgqsU855SM9uPg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v3 2/4] target-arm: Add feature parsing to
	virt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Bellows <greg.bellows@linaro.org>
Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Christoffer Dall <christoffer.dall@linaro.org>

On 27 January 2015 at 23:58, Greg Bellows <greg.bellows@linaro.org> wrote:
> Added machvirt parsing of feature keywords added to the -cpu command line
> option.  Parsing occurs during machine initialization.

> -    vbi = find_machine_info(cpu_model);
> +    /* Separate the actual CPU model name from any appended features */
> +    cpustr = g_strsplit(cpu_model, ",", 2);
> +
> +    vbi = find_machine_info(cpustr[0]);

It seems a shame we have to do this kind of manual string
fiddling in every board model, but that is definitely not a
problem to address in this patchset.

> @@ -604,6 +610,13 @@ static void machvirt_init(MachineState *machine)
>          }
>          cpuobj = object_new(object_class_get_name(oc));
>
> +        /* Handle any CPU options specfied by the user */

"specified"

> +        cc->parse_features(CPU(cpuobj), cpustr[1], &err);
> +        if (err) {
> +            error_report("%s", error_get_pretty(err));
> +            exit(1);
> +        }

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM