All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming
Date: Sat, 20 Jun 2020 15:25:19 +0100	[thread overview]
Message-ID: <CAFEAcA9C+cJ_2DdNQBckNZJEZXiG4jNPsE1HSh9bU5AOrOGMCQ@mail.gmail.com> (raw)
In-Reply-To: <20200620133207.26849-1-aleksandar.qemu.devel@gmail.com>

On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic
<aleksandar.qemu.devel@gmail.com> wrote:
> There are several places where 'kernel' is mentioned instead of
> 'qemu' in checkpatch.pl.
>
> This small series corrects this.

So, the thing about this kind of change is that it's implicitly saying "we have
forked checkpatch and will not try to update to newer versions of it from
the kernel tree", because this sort of no-behavioural-change tends to
get in the way of that kind of update by obscuring the delta between
the kernel version and ours. Effectively I think we *have* ended up
with our own fork,
simply because we haven't cared to do that kind of update from the kernel's
version and we've gradually added our own changes to our copy. But it seems
like it's worth discussing the general principle.

thanks
-- PMM


  parent reply	other threads:[~2020-06-20 14:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-20 13:32 [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming Aleksandar Markovic
2020-06-20 13:32 ` [PATCH 1/2] checkpatch: Rename top_of_kernel_tree() to top_of_qemu_tree() Aleksandar Markovic
2020-06-20 13:32 ` [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages Aleksandar Markovic
2020-06-20 15:04   ` Peter Maydell
2020-07-01 14:20     ` Paolo Bonzini
2020-07-01 14:26       ` Aleksandar Markovic
2020-07-01 12:57   ` Aleksandar Markovic
2020-06-20 14:25 ` Peter Maydell [this message]
2020-06-20 15:09   ` [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming Aleksandar Markovic
2020-06-20 15:20     ` Aleksandar Markovic
2020-06-23  8:24       ` Stefan Hajnoczi
2020-06-23  8:26 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9C+cJ_2DdNQBckNZJEZXiG4jNPsE1HSh9bU5AOrOGMCQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.