All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Liviu Ionescu" <ilg@livius.net>
Subject: Re: [PATCH 0/2] gdbstub: don't crash if no gdb attached and gdb syscall attempted
Date: Fri, 10 Jun 2022 14:04:32 +0100	[thread overview]
Message-ID: <CAFEAcA9CA_eD19OcvXh_UmZyV3Lu21tC1=X04eMYkifz3+7UrQ@mail.gmail.com> (raw)
In-Reply-To: <20220526190053.521505-1-peter.maydell@linaro.org>

On Thu, 26 May 2022 at 20:00, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> This patchset fixes a couple of bugs reported by
> Liviu Ionescu related to semihosting syscall handling.
>
> Firstly, if the user sets up the gdbstub but doesn't connect a gdb
> (ie passes '-s' but not '-S'), and we try to use gdb for semihosting
> syscalls (either because the user explicitly set target=gdb or else
> via autodetection) then we currently segfault.  This patch adjusts
> the behaviour so that "gdbstub initialized but no gdb attached to a
> vCPU" is treated the same way we already treat "gdbstub not
> initialized".
>
> Secondly, we weren't handling commandlines where
> --semihosting-config appears multiple times: these ought to be
> merged together but instead we were effectively ignoring
> all but the last one.
>
> thanks
> -- PMM
>
> Peter Maydell (2):
>   gdbstub: Don't use GDB syscalls if no GDB is attached
>   semihosting/config: Merge --semihosting-config option groups

I'll take these via target-arm.next.

thanks
-- PMM


  parent reply	other threads:[~2022-06-10 13:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 19:00 [PATCH 0/2] gdbstub: don't crash if no gdb attached and gdb syscall attempted Peter Maydell
2022-05-26 19:00 ` [PATCH 1/2] gdbstub: Don't use GDB syscalls if no GDB is attached Peter Maydell
2022-05-29 11:06   ` Philippe Mathieu-Daudé via
2022-06-09 20:01   ` Luc Michel
2022-05-26 19:00 ` [PATCH 2/2] semihosting/config: Merge --semihosting-config option groups Peter Maydell
2022-06-09 20:02   ` Luc Michel
2022-06-10 13:04 ` Peter Maydell [this message]
2022-06-10 14:40   ` [PATCH 0/2] gdbstub: don't crash if no gdb attached and gdb syscall attempted Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9CA_eD19OcvXh_UmZyV3Lu21tC1=X04eMYkifz3+7UrQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=ilg@livius.net \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.