Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

From: Peter Maydell <peter.maydell@linaro.org>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Alexander Graf" <agraf@suse.de>,
	"Luiz Capitulino" <lcapitulino@redhat.com>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	"Alex Bligh" <alex@alex.org.uk>,
	"Cornelia Huck" <cornelia.huck@de.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support
Date: Wed, 4 Jun 2014 10:33:36 +0100	[thread overview]
Message-ID: <CAFEAcA9E2cAv7HdAvwcGHJ8RWq1gN2d+mrbdP+6utyQGeejoRw@mail.gmail.com> (raw)
In-Reply-To: <538EE73D.4080408@ozlabs.ru>

On 4 June 2014 10:30, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> On 06/04/2014 07:16 PM, Peter Maydell wrote:
>> On 4 June 2014 09:08, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>>> This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported.
>>>
>>> The change to existing behaviour is that x86 only delivers NMI to
>>> the current monitored CPU now, not to every CPU.
>>
>> So this series means that the "nmi" command and handler does
>>  * NMI on x86
>>  * reset on PPC
>
> The vector is called "reset" but it is an interrupt, and I do not see any
> way to mask it.
>
>>  * restart on S390
>
> The vector is called "restart" but it is still an interrupt.

So? ARM has an interrupt called "NMI" but there's zero reason
you'd want to poke it from the monitor, any more than you'd
want to try to hand-send any other kind of interrupt.

>> That doesn't seem generic at all, and suggests this should
>> not be a common CPU method/callback.
>
> Oh. Ok. Suggestions?

I dunno. What are you actually trying to achieve?

thanks
-- PMM