From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUsBp-0008LS-AN for qemu-devel@nongnu.org; Mon, 18 Jun 2018 07:19:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUsBj-0007xs-Jd for qemu-devel@nongnu.org; Mon, 18 Jun 2018 07:19:17 -0400 Received: from mail-ot0-x241.google.com ([2607:f8b0:4003:c0f::241]:39053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUsBj-0007xX-El for qemu-devel@nongnu.org; Mon, 18 Jun 2018 07:19:11 -0400 Received: by mail-ot0-x241.google.com with SMTP id l15-v6so18011288oth.6 for ; Mon, 18 Jun 2018 04:19:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180608200150.7032-1-programmingkidx@gmail.com> References: <20180608200150.7032-1-programmingkidx@gmail.com> From: Peter Maydell Date: Mon, 18 Jun 2018 12:18:50 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Arbuckle Cc: QEMU Developers On 8 June 2018 at 21:01, John Arbuckle wrote: > Fix the cocoa front-end to correctly be able to use absolute mode. > > Signed-off-by: John Arbuckle This commit message is insufficiently detailed, which makes it hard to review the patch. When you send patches, please can you provide commit messages which describe what the problem is, where the current code gets things wrong and why the changes fix the issue? It is painful to have to reverse-engineer your design from your code changes. thanks -- PMM