From: Peter Maydell <peter.maydell@linaro.org>
To: Klaus Jensen <its@irrelevant.dk>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
Qemu-block <qemu-block@nongnu.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
"Gollu Appalanaidu" <anaidu.gollu@samsung.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Max Reitz" <mreitz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v3 3/5] hw/nvme: fix out-of-bounds reads
Date: Mon, 19 Jul 2021 10:15:13 +0100 [thread overview]
Message-ID: <CAFEAcA9Hqr-piQGs4yObva3Wvr=F63OweWqqGjZBDHTkypTybg@mail.gmail.com> (raw)
In-Reply-To: <20210714060125.994882-4-its@irrelevant.dk>
On Wed, 14 Jul 2021 at 07:01, Klaus Jensen <its@irrelevant.dk> wrote:
>
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Peter noticed that mmio access may read into the NvmeParams member in
> the NvmeCtrl struct.
>
> Fix the bounds check.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/ctrl.c | 27 +++++++++++++++------------
> 1 file changed, 15 insertions(+), 12 deletions(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2021-07-19 9:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 6:01 [PATCH v3 0/5] hw/nvme: fix mmio read Klaus Jensen
2021-07-14 6:01 ` [PATCH v3 1/5] hw/nvme: split pmrmsc register into upper and lower Klaus Jensen
[not found] ` <CGME20210714113905epcas5p3d582216af16ab401f806757cad6bcc8d@epcas5p3.samsung.com>
2021-07-14 11:35 ` Gollu Appalanaidu
2021-07-19 9:13 ` Peter Maydell
2021-07-19 9:32 ` Klaus Jensen
2021-07-14 6:01 ` [PATCH v3 2/5] hw/nvme: use symbolic names for registers Klaus Jensen
2021-07-14 9:08 ` Philippe Mathieu-Daudé
[not found] ` <CGME20210714114548epcas5p41a562395f6b695aabcfa4a531f2285d3@epcas5p4.samsung.com>
2021-07-14 11:42 ` Gollu Appalanaidu
2021-07-14 6:01 ` [PATCH v3 3/5] hw/nvme: fix out-of-bounds reads Klaus Jensen
2021-07-19 8:50 ` Stefan Hajnoczi
2021-07-19 9:15 ` Peter Maydell [this message]
2021-07-14 6:01 ` [PATCH v3 4/5] hw/nvme: fix mmio read Klaus Jensen
2021-07-19 9:52 ` Peter Maydell
2021-07-14 6:01 ` [PATCH v3 5/5] tests/qtest/nvme-test: add mmio read test Klaus Jensen
[not found] ` <CGME20210714120156epcas5p212ae986c7e2ed4d30191ce8915304d2c@epcas5p2.samsung.com>
2021-07-14 11:58 ` Gollu Appalanaidu
2021-07-19 6:43 ` [PATCH v3 0/5] hw/nvme: fix mmio read Klaus Jensen
2021-07-19 8:52 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9Hqr-piQGs4yObva3Wvr=F63OweWqqGjZBDHTkypTybg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=anaidu.gollu@samsung.com \
--cc=fam@euphon.net \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.