From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ReFR7-000217-P6 for qemu-devel@nongnu.org; Fri, 23 Dec 2011 19:26:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ReFR6-0002YN-Tf for qemu-devel@nongnu.org; Fri, 23 Dec 2011 19:26:05 -0500 Received: from mail-qy0-f173.google.com ([209.85.216.173]:49859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ReFR6-0002YJ-MZ for qemu-devel@nongnu.org; Fri, 23 Dec 2011 19:26:04 -0500 Received: by qcsd15 with SMTP id d15so6292426qcs.4 for ; Fri, 23 Dec 2011 16:26:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1324578014-24746-3-git-send-email-mark.langsdorf@calxeda.com> References: <1324578014-24746-1-git-send-email-mark.langsdorf@calxeda.com> <1324578014-24746-3-git-send-email-mark.langsdorf@calxeda.com> Date: Sat, 24 Dec 2011 00:26:04 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/9] arm: Set frequencies for arm_timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Langsdorf Cc: kwolf@redhat.com, qemu-devel@nongnu.org, paul@codesourcery.com On 22 December 2011 18:20, Mark Langsdorf wrot= e: > Use qdev properties to allow board modelers to set the frequencies > for the sp804 timer. Each of the sp804's timers can have an > individual frequency. The timers default to 1MHz. > > + =C2=A0 =C2=A0/* The timers are configurable between 32kHz and 1MHz > + =C2=A0 =C2=A0 * defaulting to 1MHz but overrideable as a property > + =C2=A0 =C2=A0 * They can be configured individually as a property > + =C2=A0 =C2=A0 * but default is shared frequency */ You've forgotten to update this comment when you dropped the shared-frequency property. Patch looks good otherwise. -- PMM