From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A167EC433EF for ; Tue, 3 May 2022 16:18:44 +0000 (UTC) Received: from localhost ([::1]:58854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlvEZ-0007S4-MO for qemu-devel@archiver.kernel.org; Tue, 03 May 2022 12:18:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlvBD-0003ax-UF for qemu-devel@nongnu.org; Tue, 03 May 2022 12:15:19 -0400 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]:44925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nlvBC-0005P2-5E for qemu-devel@nongnu.org; Tue, 03 May 2022 12:15:15 -0400 Received: by mail-yb1-xb2d.google.com with SMTP id e12so31864419ybc.11 for ; Tue, 03 May 2022 09:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rfZyMNEHSzH0zE8jrXafSKc+DRkhdHsZVQWiTcQYkfA=; b=kE/Z8pHLD342+qGxW2+bpmiEv7FhZHX4B2Kpr8g71fGQkZvAcXNLkjjN99LJPG+bN9 Pr7VaW/j78GR9PflF+G1qSawDEpCKkkmqNLEAaJl0zLe0a/kvlwnENySamjASXy/KHjW cxoYyYB2V9q4qwcCOCtnf5635Qo7b52YCeUmV760qWth9xEZsWoOnN9s38NV1KeFJXf8 JjeZbANQLyDlPEN5sqzMQ/Sgj8Yv/pIENVR2kydwtK6gNnreexZuI31fZCtPc6Uqn9Iq 2knCGO7+OWEhNApAanVC65ZLOh66aFTeqjTDtDCGSyLy8GmOA0kYVs15x7skaBpXuon/ 4/3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rfZyMNEHSzH0zE8jrXafSKc+DRkhdHsZVQWiTcQYkfA=; b=c7L8AwruaOt6T8+MNNMJGKveXwPR2oy/GXPqi9/vWOnTfIMKMxylGGFegRmGVyKPfC Yvx1nQPhQmZgzxlSJ8neqFWYkjWKrQkUf12aXbBpl9/1y8OSS5VA/C5/R6ZwBB00mmuB 6utFcJCzCMSQpscdM17Fgz0Ah+cUvD++gZHLkPfeA3IvLcDPc2bmSpQudIum1SqnbDS+ Hq/tHLbRajdkzTYr+3ChaQKKKOPCvquOJQFgu8cc1cjP10zFpZYfBxwP9yjdGXi2OBUv tF86tQtQKQhN+CrazjhA0p4GMzvXujVkMIjKf3MSkx2aJXlhc1Xvxp32bQEbOD3SPp0r 2V3w== X-Gm-Message-State: AOAM532dMnA0+XJt4SkgqcVdEIpd4ZCP8FkNBkn6kr6SBexmjRak6w58 wFTK1zgMM37iTfV4oznT+ekaUSzUCm0Uma4YunmRVg== X-Google-Smtp-Source: ABdhPJw/EoamkFusTiwsWbNZH4jQE5cQIjDkb30W6jn3G+05HWts2wzcjPAcyMsWAwCcGJt8NtONbREOzHaC2lSTSqY= X-Received: by 2002:a05:6902:1543:b0:649:3124:b114 with SMTP id r3-20020a056902154300b006493124b114mr14780547ybu.39.1651594513080; Tue, 03 May 2022 09:15:13 -0700 (PDT) MIME-Version: 1.0 References: <20220501055028.646596-1-richard.henderson@linaro.org> <20220501055028.646596-15-richard.henderson@linaro.org> In-Reply-To: <20220501055028.646596-15-richard.henderson@linaro.org> From: Peter Maydell Date: Tue, 3 May 2022 17:15:02 +0100 Message-ID: Subject: Re: [PATCH v4 14/45] target/arm: Consolidate cpreg updates in add_cpreg_to_hashtable To: Richard Henderson Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b2d; envelope-from=peter.maydell@linaro.org; helo=mail-yb1-xb2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, 1 May 2022 at 07:06, Richard Henderson wrote: > > Put most of the value writeback to the same place, > and improve the comment that goes with them. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 28 ++++++++++++---------------- > 1 file changed, 12 insertions(+), 16 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM