From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58087)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YgEtC-0000at-NV
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 12:01:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YgEt8-0004i7-F5
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 12:01:10 -0400
Received: from mail-ie0-f175.google.com ([209.85.223.175]:32873)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YgEt8-0004i2-AM
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 12:01:06 -0400
Received: by iebmp1 with SMTP id mp1so104573997ieb.0
	for <qemu-devel@nongnu.org>; Thu, 09 Apr 2015 09:01:05 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <87y4m1z49y.fsf@linaro.org>
References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com>
	<1428055432-12120-13-git-send-email-zhaoshenglong@huawei.com>
	<87y4m1z49y.fsf@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 9 Apr 2015 17:00:45 +0100
Message-ID: <CAFEAcA9OqtuV8y=gESYtP4J2+MPz_u8wnCm_JJ1oYoXUXshTDw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 12/20] hw/arm/virt-acpi-build: Add PCIe
 info and generate MCFG table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: Mark Salter <msalter@redhat.com>, hangaohuai@huawei.com, Igor Mammedov <imammedo@redhat.com>, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, "Michael S. Tsirkin" <mst@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, Hanjun Guo <hanjun.guo@linaro.org>, Shannon Zhao <zhaoshenglong@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 9 April 2015 at 16:54, Alex Benn=C3=A9e <alex.bennee@linaro.org> wrote:
>
> Shannon Zhao <zhaoshenglong@huawei.com> writes:
>
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>> +build_mcfg(GArray *table_data, GArray *linker, VirtGuestInfo *guest_inf=
o)
>> +{
>> +    AcpiTableMcfg *mcfg;
>> +    acpi_pcie_info *info =3D guest_info->pcie_info;
>> +    int len =3D sizeof(*mcfg) + 1 * sizeof(mcfg->allocation[0]);
>
> Explicit bracketing around the maths please.

This doesn't seem to make much sense anyway:
if the addition was intended to take precedence
then we're adding 1 to a size-of-a-struct, which is
a bit weird. And if the multiplication was intended
to take precedence then it's doing a pointless multiply
by one. Please can you check that this is actually
calculating the right value?

thanks
-- PMM