From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBrZL-00039f-5f for qemu-devel@nongnu.org; Wed, 03 Apr 2019 21:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBrPy-00063P-8h for qemu-devel@nongnu.org; Wed, 03 Apr 2019 21:43:51 -0400 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:40395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBrPx-0005sm-H5 for qemu-devel@nongnu.org; Wed, 03 Apr 2019 21:43:49 -0400 Received: by mail-ot1-x341.google.com with SMTP id t8so852338otp.7 for ; Wed, 03 Apr 2019 18:43:38 -0700 (PDT) MIME-Version: 1.0 References: <20190329200445.28512-1-chen.zhang@intel.com> In-Reply-To: <20190329200445.28512-1-chen.zhang@intel.com> From: Peter Maydell Date: Thu, 4 Apr 2019 08:43:27 +0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen Cc: "Dr. David Alan Gilbert" , qemu-dev , John Snow , Fam Zheng On Sat, 30 Mar 2019 at 03:09, Zhang Chen wrote: > > From: Zhang Chen > > In current codes we use change_bit() to finish the job. > > Signed-off-by: Zhang Chen > --- > include/qemu/bitmap.h | 1 - > include/qemu/bitops.h | 15 --------------- > 2 files changed, 16 deletions(-) Do we gain anything by removing this function? IIRC these functions are all borrowed from the Linux kernel, so keeping the same API as the kernel does would make sense to me, even if we happen not to use all of it right now. thanks -- PMM