From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz0QB-0001pK-0P for qemu-devel@nongnu.org; Tue, 25 Oct 2016 08:01:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz0Q5-0007Ew-W0 for qemu-devel@nongnu.org; Tue, 25 Oct 2016 08:01:35 -0400 Received: from mail-ua0-x236.google.com ([2607:f8b0:400c:c08::236]:38335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bz0Q5-0007EZ-RY for qemu-devel@nongnu.org; Tue, 25 Oct 2016 08:01:29 -0400 Received: by mail-ua0-x236.google.com with SMTP id t11so12342717uaa.5 for ; Tue, 25 Oct 2016 05:01:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1477361273-18888-1-git-send-email-linux@roeck-us.net> References: <1477361273-18888-1-git-send-email-linux@roeck-us.net> From: Peter Maydell Date: Tue, 25 Oct 2016 13:01:08 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] hw/arm/pxa2xx: Set value default values for CCCR and CKEN on PXA255 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Guenter Roeck Cc: QEMU Developers On 25 October 2016 at 03:07, Guenter Roeck wrote: > The code used default values for PXA270 to configure CCCR. For PXA255, > the resulting register value is invalid (unsupported) and resulted > in a division by zero in the Linux kernel. Use default values from > datasheet instead. > > Signed-off-by: Guenter Roeck > --- > hw/arm/pxa2xx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c > index 2a2a821..4d9aed4 100644 > --- a/hw/arm/pxa2xx.c > +++ b/hw/arm/pxa2xx.c > @@ -2274,7 +2274,9 @@ PXA2xxState *pxa255_init(MemoryRegion *address_space, unsigned int sdram_size) > qdev_get_gpio_in(s->pic, PXA2XX_PIC_LCD)); > > s->cm_base = 0x41300000; > - s->cm_regs[CCCR >> 2] = 0x02000210; /* 416.0 MHz */ > + s->cm_regs[CCCR >> 2] = 0x00000121; /* from datasheet */ > + s->cm_regs[CKEN >> 2] = 0x00017def; /* from datasheet */ > + > s->clkcfg = 0x00000009; /* Turbo mode active */ > memory_region_init_io(&s->cm_iomem, NULL, &pxa2xx_cm_ops, s, "pxa2xx-cm", 0x1000); > memory_region_add_subregion(address_space, s->cm_base, &s->cm_iomem); Applied to target-arm.next, thanks (I've fixed the tabs-vs-spaces style nit that checkpatch gripes about). -- PMM