From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQLZ6-0005Ru-Vl for qemu-devel@nongnu.org; Mon, 22 Oct 2012 13:13:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQLZ5-0001YS-PF for qemu-devel@nongnu.org; Mon, 22 Oct 2012 13:13:24 -0400 Received: from mail-ia0-f173.google.com ([209.85.210.173]:43520) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQLZ5-0001YJ-Kr for qemu-devel@nongnu.org; Mon, 22 Oct 2012 13:13:23 -0400 Received: by mail-ia0-f173.google.com with SMTP id m10so2306496iam.4 for ; Mon, 22 Oct 2012 10:13:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5085122F.1040106@siemens.com> References: <1350897839-29593-1-git-send-email-pingfank@linux.vnet.ibm.com> <1350897839-29593-9-git-send-email-pingfank@linux.vnet.ibm.com> <5085122F.1040106@siemens.com> Date: Mon, 22 Oct 2012 18:13:21 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Liu Ping Fan , Stefan Hajnoczi , Marcelo Tosatti , "qemu-devel@nongnu.org" , Avi Kivity , Anthony Liguori , Paolo Bonzini On 22 October 2012 10:30, Jan Kiszka wrote: > Can't we enhance qemu-tls.h to work via pthread_setspecific in case > __thread is not working and use that abstraction (DECLARE/DEFINE_TLS) > directly? Agreed. (There were prototype patches floating around for Win32 at least). The only reason qemu-tls.h has the dummy not-actually-tls code for non-linux is that IIRC we wanted to get the linux bits in quickly before a release and we never got round to going back and doing it properly for the other targets. -- PMM