From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSlhX-0000qR-1V
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 08:17:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSlhW-00067i-9C
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 08:17:58 -0500
Received: from mail-vk0-x235.google.com ([2607:f8b0:400c:c05::235]:34373)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aSlhW-00067X-47
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 08:17:58 -0500
Received: by mail-vk0-x235.google.com with SMTP id e185so94612936vkb.1
	for <qemu-devel@nongnu.org>; Mon, 08 Feb 2016 05:17:58 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1454683067-16001-1-git-send-email-peter.maydell@linaro.org>
References: <1454683067-16001-1-git-send-email-peter.maydell@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 8 Feb 2016 13:17:38 +0000
Message-ID: <CAFEAcA9RBtFw75=UF3tSS8uK-EF7OuhSDVfNdhuHOx-8KiPdyg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH 0/3] target-arm: Fix IL in
 syndromes for FP and copro traps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, Patch Tracking <patches@linaro.org>

On 5 February 2016 at 14:37, Peter Maydell <peter.maydell@linaro.org> wrote:
> This series corrects a bug I noticed while reading the code.
>
> In syndrome register values, the IL bit indicates the instruction
> length, and is 1 for 4-byte instructions and 0 for 2-byte
> instructions.  All A64 and A32 instructions are 4-byte, but Thumb
> instructions may be either 2 or 4 bytes long.  Unfortunately we named
> the parameter to the syn_* functions for constructing syndromes
> "is_thumb", which falsely implies that it should be set for all Thumb
> instructions, rather than only the 16-bit ones.
>
> Fix the parameter names to a less confusing "is_16bit", and
> correct the places where we should be passing in 'false' rather
> than 's->thumb' for syndrome construction, which are the
> coprocessor, VFP and Neon instruction traps (all these are always
> 32-bit for Thumb).
>
> The calls to syn_aa32_svc() and syn_aa32_bkpt() correctly still
> use s->thumb, because for SVC and BKPT the Thumb encoding is 16
> bits but the ARM encoding is 32 bits.

Applied to target-arm.next, thanks.

-- PMM