From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQuxu-0005o0-1W for qemu-devel@nongnu.org; Wed, 03 Feb 2016 05:47:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQuxt-0002ln-14 for qemu-devel@nongnu.org; Wed, 03 Feb 2016 05:47:13 -0500 Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:34416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQuxs-0002lh-St for qemu-devel@nongnu.org; Wed, 03 Feb 2016 05:47:12 -0500 Received: by mail-vk0-x22f.google.com with SMTP id e185so10817777vkb.1 for ; Wed, 03 Feb 2016 02:47:12 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <56B1A90E.3000506@msgid.tls.msk.ru> References: <1454005340-15682-1-git-send-email-wei@redhat.com> <56B1A90E.3000506@msgid.tls.msk.ru> From: Peter Maydell Date: Wed, 3 Feb 2016 10:46:52 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Wei Huang , QEMU Trivial , Shannon Zhao , QEMU Developers , Shannon Zhao On 3 February 2016 at 07:15, Michael Tokarev wrote: > 28.01.2016 21:22, Wei Huang wrote: >> When QEMU is hook'ed up with libvirt/virsh, the first ACPI reboot >> request will succeed; but the following shutdown/reboot requests >> fail to trigger VMs to react. Notice that in mach-virt machine >> model GPIO is defined as edge-triggered and active-high in ACPI. >> This patch changes the behavior of powerdown notifier from PULLUP >> to PULSE. It solves the problem described above (i.e. reboot >> continues to work). > > So, what's the outcome of this? :) This patch is definitely wrong. The patch to fix up the gpio reset stuff is definitely the right idea. Whether it fixes the reported failure or some further change is also needed is currently unclear. thanks -- PMM