All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, public@hansmi.ch
Subject: Re: [Qemu-devel] [PATCH for-3.1 v3 1/2] usb-mtp: fix utf16_to_str
Date: Mon, 3 Dec 2018 14:59:06 +0000	[thread overview]
Message-ID: <CAFEAcA9ToxMAjKBzKfs-1UhhLk0Dr_cTa31EcA+SrMJqt6v9dQ@mail.gmail.com> (raw)
In-Reply-To: <20181203101045.27976-2-kraxel@redhat.com>

On Mon, 3 Dec 2018 at 10:15, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Make utf16_to_str return an allocated string.  Remove the assumtion that
> the number of string bytes equals the number of utf16 chars (which is
> only true for ascii chars).  Instead call wcstombs twice, once to figure
> the storage size and once for the actual conversion (as suggested by the
> wcstombs manpage).
>
> Reported-by: Michael Hanselmann <public@hansmi.ch>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb/dev-mtp.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

  reply	other threads:[~2018-12-03 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 10:10 [Qemu-devel] [PATCH for-3.1 v3 0/2] usb-mtp: two bugfixes (one security fix) Gerd Hoffmann
2018-12-03 10:10 ` [Qemu-devel] [PATCH for-3.1 v3 1/2] usb-mtp: fix utf16_to_str Gerd Hoffmann
2018-12-03 14:59   ` Peter Maydell [this message]
2018-12-03 16:11   ` Philippe Mathieu-Daudé
2018-12-03 18:10   ` Markus Armbruster
2018-12-03 10:10 ` [Qemu-devel] [PATCH for-3.1 v3 2/2] usb-mtp: outlaw slashes in filenames Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9ToxMAjKBzKfs-1UhhLk0Dr_cTa31EcA+SrMJqt6v9dQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=public@hansmi.ch \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.