From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5725EC433DB for ; Thu, 4 Mar 2021 11:41:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C977664EED for ; Thu, 4 Mar 2021 11:41:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C977664EED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHmMe-0002HM-PD for qemu-devel@archiver.kernel.org; Thu, 04 Mar 2021 06:41:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHmLf-0001CZ-DW for qemu-devel@nongnu.org; Thu, 04 Mar 2021 06:40:55 -0500 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:39357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHmLb-0006PT-Iw for qemu-devel@nongnu.org; Thu, 04 Mar 2021 06:40:55 -0500 Received: by mail-ed1-x52b.google.com with SMTP id h10so34298852edl.6 for ; Thu, 04 Mar 2021 03:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pc5OZ/q6ft25WXrEaV90BsKQ6D6IusnYR/G4yIr/FJc=; b=tCZDG4v3bbQ5Hyf2dA6Cg2aBK3qcoMLP8e4Hsm4W8T4ry7NuHDZNjaW4c/sDLiD8Zv QaSFu9PXDV+v1sjIViRY6ejjvGAtvlu5pt/fRufD2nqNHHCK6cDgAXlVw0NWrJ6bQZkY tPzRnnZFWtmbmXXoACAUEIzcucj6e5imCJJfQDmsZp1KZoD8MxdTMy6E7MwpST93uebF KVFxVgzqG6GMu9ORRqk+qAm/M+EGYnGpXpFkpSiOUCdNrqUk4d6V4LhZ9eOcfDfUJJhC E/hitOrH7mRDR43wekTF5ldg2Uf1AjaS8mNcAczG12GiiWdVHXA0C8+My5kco+6BlQY3 LJCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pc5OZ/q6ft25WXrEaV90BsKQ6D6IusnYR/G4yIr/FJc=; b=JTnT5OeAPZ9eND6TT4D6AGTDiVTVENJc+9Wn8u8k1DyKHHFWl8XFEm34RDffQwgz4F 7cg66xmg11f9QagMtJCWIjGOiZsM1wh+JRWLGUtPgznC6yJ/UeLi/dXGPw/XG6DSGSCa Cketwk6v0OW5B7sigDfYzBkMXYDG6QtfTHITwSM7uJ7xrTfaW1K0DOYJONaYnYFKFGvM Rp4LmxPwHUMhc2dsjZ6tgX4trmCw4ISq0REuM1FZG93BlWXIb1uhPv+otvDJ0TZGOviU nJGeDgGQriXbHFmBNgKOHqruQ12hyJqy2uyugNlO/NwB/l6kviVMSJgQah8ua8/FNnw7 eIJQ== X-Gm-Message-State: AOAM530RUAe8Q2nPUv4e+TA1ysMHbhpwP/LI8gRXz2G+tAqt8/z4YiLV rtlkrU54+AXEU0M0swdn5Y2Sh5NPDFEoNXmvCdDsug== X-Google-Smtp-Source: ABdhPJwxqgOxQ0cCXDU0worHBd6j4/7XkQI97XLP6u/rsTZrF4fPB9Ve5idSLsYcgisE3K9w874G6iSOgMbVn1VrLk4= X-Received: by 2002:a50:d307:: with SMTP id g7mr3824082edh.204.1614858050044; Thu, 04 Mar 2021 03:40:50 -0800 (PST) MIME-Version: 1.0 References: <20210205144345.2068758-1-f4bug@amsat.org> <20210205144345.2068758-9-f4bug@amsat.org> In-Reply-To: <20210205144345.2068758-9-f4bug@amsat.org> From: Peter Maydell Date: Thu, 4 Mar 2021 11:40:34 +0000 Message-ID: Subject: Re: [PATCH 8/9] hw/arm/virt: Restrict 32-bit CPUs to TCG To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Qemu-block , Andrew Jones , QEMU Developers , qemu-arm , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 5 Feb 2021 at 14:44, Philippe Mathieu-Daud=C3=A9 = wrote: > > Support for ARMv7 has been dropped in commit 82bf7ae84ce > ("target/arm: Remove KVM support for 32-bit Arm hosts"). > Restrict the 32-bit CPUs to --enable-tcg builds. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/arm/virt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index f5e4a6ec914..ab6300650f9 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -197,8 +197,10 @@ static const int a15irqmap[] =3D { > }; > > static const char *valid_cpus[] =3D { > +#ifdef CONFIG_TCG > ARM_CPU_TYPE_NAME("cortex-a7"), > ARM_CPU_TYPE_NAME("cortex-a15"), > +#endif /* CONFIG_TCG */ > #ifdef TARGET_AARCH64 > ARM_CPU_TYPE_NAME("cortex-a53"), > ARM_CPU_TYPE_NAME("cortex-a57"), How painful would it be to just have it check whether the CPU type is present in the executable, rather than hard-coding an ifdef ? I think that if you try to run the virt board with command line arguments that (implicitly or explicitly) mean you've asked for a CPU which isn't present in the QEMU executable, it should give an error rather than silently selecting something else. thanks -- PMM