From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E763DC433F5 for ; Thu, 21 Apr 2022 19:06:26 +0000 (UTC) Received: from localhost ([::1]:41200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhc8H-0006pY-VO for qemu-devel@archiver.kernel.org; Thu, 21 Apr 2022 15:06:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhc5Q-0002cb-4R for qemu-devel@nongnu.org; Thu, 21 Apr 2022 15:03:28 -0400 Received: from mail-yb1-xb35.google.com ([2607:f8b0:4864:20::b35]:38878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhc5O-00017K-Kp for qemu-devel@nongnu.org; Thu, 21 Apr 2022 15:03:27 -0400 Received: by mail-yb1-xb35.google.com with SMTP id v10so1627352ybe.5 for ; Thu, 21 Apr 2022 12:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dKAqNwSjuF4Jer6ESkumxxdY5oMxfCCe6OlVsGiKvn4=; b=vf9U9zlUQTzG4l6HX1VCd0mHCg3v+FT8NWmsNG7M1cT+jyA5yiXIQ6oqzVqwBL49Lv v6MgHoFn1LLZXVT6tbP2SNq7MNIi/X3YYukzTO1xAtFx0qIy/OG8wT2nDRSY5l/6g+Sa ZjPcc/g2vwIPc/lYG2NgNNnlaZl81IQhSOBJq8z1hHh/PeOZNhe47o93ehtOlWr90uOZ VvxOjgwJIaEmXhojPCc0FpigoSlM4oeMuGNM0AaFkKHOUk2q0rI36Pvsml2XW/0hWl4M 6tINRcGVEIYZanK8hTuBlSs/mCNblwez9KxOigt/KZjn13rvzHj4LEP83y8k6Nrxgq6f cSBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dKAqNwSjuF4Jer6ESkumxxdY5oMxfCCe6OlVsGiKvn4=; b=YtBUoEp444l7+oNu3L4nLq1/YKUPghrxdwP2rnqwCjJsmBHlGdANh+egpT1ZOq95nL yBDx9A5nCDJ4WXX5mfYIKw1jRNGDjoe0deCjel5iH2R5I2WTaqp8tXRVzJUd9TstfjYs VcDrhVDTY9g0yQObzQ2Jd2B2vCsT1eDkqoa581gZaKfTm0DXsRdHvlupP/6a2qThktQ4 Fp8GH/ruMBxaH5jkkmJiQbkvF/cI8BspGTE68PMJ6PcGOb5PfIZOXqZnG3GJgyfqKOW+ e5cKfWTgv6aAUA4zsqjZp1PPUuOtFC4QIBpymZuSO/CRqJ9HiYVgAMB3CbjrFHVM8FJe 8ZeA== X-Gm-Message-State: AOAM5314POseafqsr+wm2AXogIPaP47ybtnnIFRGc9oMXE3/WjivFkwJ kk59YC41SMiHSS5XPCA0fEsTcF4uZdwudgxYNx9LqA== X-Google-Smtp-Source: ABdhPJw5nB8IRukuX8rCDHP1a0vE++olat1B8fecaEdxycFZ8cJ3YInQTyYGAstruiBDXtjBws/Lji0DHT/Z6kKtBS8= X-Received: by 2002:a05:6902:390:b0:645:7d46:f1db with SMTP id f16-20020a056902039000b006457d46f1dbmr1161896ybs.85.1650567804574; Thu, 21 Apr 2022 12:03:24 -0700 (PDT) MIME-Version: 1.0 References: <20220417174426.711829-1-richard.henderson@linaro.org> <20220417174426.711829-19-richard.henderson@linaro.org> In-Reply-To: <20220417174426.711829-19-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 21 Apr 2022 20:03:13 +0100 Message-ID: Subject: Re: [PATCH v3 18/60] target/arm: Use tcg_constant in translate-m-nocp.c To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b35; envelope-from=peter.maydell@linaro.org; helo=mail-yb1-xb35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, 17 Apr 2022 at 19:02, Richard Henderson wrote: > > Use tcg_constant_{i32,i64} as appropriate throughout. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-m-nocp.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/target/arm/translate-m-nocp.c b/target/arm/translate-m-nocp.c > index d9e144e8eb..27363a7b4e 100644 > --- a/target/arm/translate-m-nocp.c > +++ b/target/arm/translate-m-nocp.c > @@ -173,7 +173,7 @@ static bool trans_VSCCLRM(DisasContext *s, arg_VSCCLRM *a) > } > > /* Zero the Sregs from btmreg to topreg inclusive. */ > - zero = tcg_const_i64(0); > + zero = tcg_constant_i64(0); > if (btmreg & 1) { > write_neon_element64(zero, btmreg >> 1, 1, MO_32); > btmreg++; Looks like we were previously leaking the TCGv for this one? Reviewed-by: Peter Maydell thanks -- PMM