From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHTSm-0001gv-Ms for qemu-devel@nongnu.org; Mon, 27 Jun 2016 06:08:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHTSk-0003Mq-PW for qemu-devel@nongnu.org; Mon, 27 Jun 2016 06:08:19 -0400 Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:35651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHTSk-0003Mk-Gy for qemu-devel@nongnu.org; Mon, 27 Jun 2016 06:08:18 -0400 Received: by mail-vk0-x22f.google.com with SMTP id j2so225480429vkg.2 for ; Mon, 27 Jun 2016 03:08:18 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <87oa6nhv7b.fsf@dusky.pond.sub.org> References: <1466777957-5126-1-git-send-email-armbru@redhat.com> <1466777957-5126-2-git-send-email-armbru@redhat.com> <576D49AA.30906@redhat.com> <87oa6nhv7b.fsf@dusky.pond.sub.org> From: Peter Maydell Date: Mon, 27 Jun 2016 11:07:58 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Eric Blake , QEMU Developers , Paolo Bonzini On 27 June 2016 at 09:50, Markus Armbruster wrote: > To spice up things, we > also name a few of our headers just like system headers we use > elsewhere, e.g. "util.h" in net/ vs. in util/qemu-openpty.c. That would be nice to fix at some point I think, it's pretty brittle. (We had one issue recently that boiled down to system header vs local header confusion, though I forget the details.) thanks -- PMM