All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v2 10/14] sm501: Add support for panel layer
Date: Thu, 2 Mar 2017 20:46:10 +0000	[thread overview]
Message-ID: <CAFEAcA9VQWC3Qqosm6EnoBK_Z-z33rVNyDUi=JkkHKWW2=Dvjw@mail.gmail.com> (raw)
In-Reply-To: <alpine.BSF.2.20.1703022113370.83701@zero.eik.bme.hu>

On 2 March 2017 at 20:15, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> On Thu, 2 Mar 2017, Peter Maydell wrote:
>>
>> This is another refactoring that's unrelated to adding panel
>> layer support, right? (It's just changing from having src and
>> offset updated at the end of the loop to dropping src and having offset
>> be updated in the for()).
>
>
> It's a clean up getting rid of the unneded src pointer. Should I move it to
> the cleanup patch or is it OK to leave it here?

I've reviewed it now, so you can leave it. It would have
been better in its own patch, though. (The general principle
is that each patch should do only one thing, and it should do
all of that one thing, and the one thing should be fairly
small and easy to understand.)

thanks
-- PMM

  reply	other threads:[~2017-03-02 20:46 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26  0:17 [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display controller emulation BALATON Zoltan
2017-02-25 18:23 ` [Qemu-devel] [PATCH v2 04/14] sm501: Get rid of base address in draw_hwc_line BALATON Zoltan
2017-03-02 19:14   ` Peter Maydell
2017-03-02 20:06     ` BALATON Zoltan
2017-02-25 18:31 ` [Qemu-devel] [PATCH v2 05/14] sm501: Add emulation of chip connected via PCI BALATON Zoltan
2017-03-02 19:22   ` Peter Maydell
2017-03-02 20:13     ` BALATON Zoltan
2017-03-02 20:43       ` Peter Maydell
2017-03-03  1:53         ` BALATON Zoltan
2017-02-25 18:46 ` [Qemu-devel] [PATCH v2 07/14] sm501: Fix device endianness BALATON Zoltan
2017-03-02 21:04   ` Peter Maydell
2017-03-03  2:15     ` BALATON Zoltan
2017-03-03 18:49       ` Peter Maydell
2017-03-03 20:11         ` BALATON Zoltan
2017-03-04 12:40           ` Peter Maydell
2017-03-04 22:58             ` BALATON Zoltan
2017-03-06 10:32               ` Peter Maydell
2017-03-06 18:46                 ` BALATON Zoltan
2017-02-25 19:19 ` [Qemu-devel] [PATCH v2 09/14] sm501: Misc clean ups BALATON Zoltan
2017-03-02 19:35   ` Peter Maydell
2017-02-25 19:25 ` [Qemu-devel] [PATCH v2 10/14] sm501: Add support for panel layer BALATON Zoltan
2017-03-02 19:44   ` Peter Maydell
2017-03-02 20:15     ` BALATON Zoltan
2017-03-02 20:46       ` Peter Maydell [this message]
2017-02-25 21:47 ` [Qemu-devel] [PATCH v2 12/14] sm501: Implement reading 2D engine registers BALATON Zoltan
2017-03-02 20:00   ` Peter Maydell
2017-03-02 20:22     ` BALATON Zoltan
2017-03-02 20:50       ` Peter Maydell
2017-02-25 23:53 ` [Qemu-devel] [PATCH v2 13/14] sm501: Add reset function and vmstate descriptor BALATON Zoltan
2017-03-02 19:51   ` Peter Maydell
2017-03-02 20:18     ` BALATON Zoltan
2017-03-02 20:49       ` Peter Maydell
2017-03-02 20:55         ` BALATON Zoltan
2017-03-02 21:05           ` BALATON Zoltan
2017-03-02 21:06           ` Peter Maydell
2017-02-26  0:31 ` [Qemu-devel] [PATCH v2 02/14] sm501: Use defines instead of constants where available BALATON Zoltan
2017-03-02 18:53   ` Peter Maydell
2017-03-02 19:03     ` Peter Maydell
2017-03-02 19:58       ` BALATON Zoltan
2017-02-26  0:31 ` [Qemu-devel] [PATCH v2 14/14] ppc: Add SM501 device in config for ppc and ppcemb targets BALATON Zoltan
2017-02-26  0:31 ` [Qemu-devel] [PATCH v2 06/14] sm501: Add missing arbitration control register BALATON Zoltan
2017-03-02 20:08   ` Peter Maydell
2017-03-02 20:09     ` Peter Maydell
2017-02-26  0:31 ` [Qemu-devel] [PATCH v2 11/14] sm501: Add some more missing registers BALATON Zoltan
2017-03-02 19:59   ` Peter Maydell
2017-03-02 20:21     ` BALATON Zoltan
2017-02-26  0:31 ` [Qemu-devel] [PATCH v2 03/14] sm501: QOMify BALATON Zoltan
2017-03-02 19:55   ` Peter Maydell
2017-02-26  0:31 ` [Qemu-devel] [PATCH v2 08/14] sm501: Fix hardware cursor BALATON Zoltan
2017-03-02 19:35   ` Peter Maydell
2017-02-26  0:31 ` [Qemu-devel] [PATCH v2 01/14] sm501: Fixed code style and a few typos in comments BALATON Zoltan
2017-02-27 18:11 ` [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display controller emulation Michael Tokarev
2017-02-27 19:03   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9VQWC3Qqosm6EnoBK_Z-z33rVNyDUi=JkkHKWW2=Dvjw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=balaton@eik.bme.hu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.