[Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

[Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

[Samuel Thibault]

The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000)

are available in the git repository at:

  http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-udp-error

for you to fetch changes up to 35ddb636fa252e92bced3dd3dc240f7bce3ad051:

  slirp: send icmp6 errors when UDP send failed (2016-03-20 14:52:32 +0100)

----------------------------------------------------------------
slirp: send icmp6 errors when UDP send failed

----------------------------------------------------------------
Samuel Thibault (1):
      slirp: send icmp6 errors when UDP send failed

 slirp/udp6.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

[Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

[Samuel Thibault]

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 slirp/udp6.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/slirp/udp6.c b/slirp/udp6.c
index 60a91c9..a23026f 100644
--- a/slirp/udp6.c
+++ b/slirp/udp6.c
@@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m)
         m->m_data -= iphlen;
         *ip = save_ip;
         DEBUG_MISC((dfd, "udp tx errno = %d-%s\n", errno, strerror(errno)));
-        /* TODO: ICMPv6 error */
-        /*icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));*/
+        icmp6_send_error(m, ICMP6_UNREACH, ICMP6_UNREACH_NO_ROUTE);
         goto bad;
     }
 
-- 
2.7.0

Re: [Qemu-devel] [PULL] slirp: send icmp6 errors when UDP send failed

[Peter Maydell]

On 20 March 2016 at 14:08, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000)
>
> are available in the git repository at:
>
>   http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-udp-error
>
> for you to fetch changes up to 35ddb636fa252e92bced3dd3dc240f7bce3ad051:
>
>   slirp: send icmp6 errors when UDP send failed (2016-03-20 14:52:32 +0100)
>
> ----------------------------------------------------------------
> slirp: send icmp6 errors when UDP send failed

This one doesn't seem to have been on the list before either.

thanks
-- PMM