From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXC6H-0003yz-UP for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:08:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXC6C-00074s-S3 for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:08:45 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:44600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXC6C-00074O-Kx for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:08:40 -0400 Received: by mail-lb0-f170.google.com with SMTP id s7so5060157lbd.1 for ; Mon, 07 Apr 2014 09:08:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <52FD9583.6080005@ozlabs.ru> References: <1391947053-26753-1-git-send-email-afaerber@suse.de> <1392004376-17016-1-git-send-email-aik@ozlabs.ru> <1392004376-17016-2-git-send-email-aik@ozlabs.ru> <52F93745.8090703@suse.de> <52FD9583.6080005@ozlabs.ru> From: Peter Maydell Date: Mon, 7 Apr 2014 17:08:19 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Alexander Graf , "qemu-ppc@nongnu.org" , =?UTF-8?Q?Andreas_F=C3=A4rber?= , QEMU Developers On 14 February 2014 04:03, Alexey Kardashevskiy wrote: > Like this? Against what should I rebase my patches and repost them? > > > diff --git a/tests/Makefile b/tests/Makefile > index 94b32b7..2577843 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -323,7 +323,9 @@ check-block: $(patsubst %,check-%, $(check-block-y)) > check: check-qapi-schema check-unit check-qtest > check-clean: > $(MAKE) -C tests/tcg clean > - rm -rf $(check-unit-y) $(check-qtest-i386-y) > $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) t > + $(eval rmlist = $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y)) > + $(foreach target,$(SYSEMU_TARGET_LIST), $(eval rmlist += > $(check-qtest-$(target)-y))) > + rm -rf $(rmlist) You don't need this intermediate rmlist variable. It should be possible to do something like rm -rf $(foreach target,$(SYSEMU_TARGET_LIST), $(check-qtest-$(target)-y)) (untested!) thanks -- PMM