[Qemu-devel] [PULL 0/5] TCG queued patches

[Qemu-devel] [PULL 0/5] TCG queued patches

[Richard Henderson]

The first tcg pull for 2.13/3.0.  Two of these are candidates
for cherry-picking into stable.


r~


The following changes since commit 26bd8d98c4b3284a4c6fe3b67c98b1edd00e9beb:

  Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.13-pull-request' into staging (2018-05-01 15:26:06 +0100)

are available in the Git repository at:

  git://github.com/rth7680/qemu.git tags/pull-tcg-20180502

for you to fetch changes up to 6001f7729e12dd1d810291e4cbf83cee8e07441d:

  tcg: workaround branch instruction overflow in tcg_out_qemu_ld/st (2018-05-01 11:56:55 -0700)

----------------------------------------------------------------
Queued TCG patches

----------------------------------------------------------------
Henry Wertz (1):
      tcg/arm: Fix memory barrier encoding

Laurent Vivier (1):
      tcg: workaround branch instruction overflow in tcg_out_qemu_ld/st

Richard Henderson (3):
      tcg: Document INDEX_mul[us]h_*
      tcg: Allow wider vectors for cmp and mul
      tcg: Improve TCGv_ptr support

 tcg/tcg-op.h             | 91 +++++++++++++++++++++++++++++++++++++-----------
 tcg/tcg.h                | 88 +++++++++++++++++++++++++++++-----------------
 target/hppa/translate.c  | 16 ++-------
 tcg/arm/tcg-target.inc.c |  4 +--
 tcg/tcg-ldst.inc.c       |  8 ++---
 tcg/tcg-op-vec.c         |  8 ++---
 tcg/tcg.c                | 33 ++----------------
 tcg/README               |  8 +++++
 8 files changed, 150 insertions(+), 106 deletions(-)

[Qemu-devel] [PULL 1/5] tcg: Document INDEX_mul[us]h_*

[Richard Henderson]

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/README | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tcg/README b/tcg/README
index bb2ea5121b..a5237a9edb 100644
--- a/tcg/README
+++ b/tcg/README
@@ -431,6 +431,14 @@ double-word product T0.  The later is returned in two single-word outputs.
 
 Similar to mulu2, except the two inputs T1 and T2 are signed.
 
+* mulsh_i32/i64 t0, t1, t2
+* muluh_i32/i64 t0, t1, t2
+
+Provide the high part of a signed or unsigned multiply, respectively.
+If mulu2/muls2 are not provided by the backend, the tcg-op generator
+can obtain the same results can be obtained by emitting a pair of
+opcodes, mul+muluh/mulsh.
+
 ********* Memory Barrier support
 
 * mb <$arg>
-- 
2.14.3

Re: [Qemu-devel] [PULL 0/5] TCG queued patches

[Peter Maydell]

On 2 May 2018 at 18:47, Richard Henderson <richard.henderson@linaro.org> wrote:
> The first tcg pull for 2.13/3.0.  Two of these are candidates
> for cherry-picking into stable.
>
>
> r~
>
>
> The following changes since commit 26bd8d98c4b3284a4c6fe3b67c98b1edd00e9beb:
>
>   Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.13-pull-request' into staging (2018-05-01 15:26:06 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/rth7680/qemu.git tags/pull-tcg-20180502
>
> for you to fetch changes up to 6001f7729e12dd1d810291e4cbf83cee8e07441d:
>
>   tcg: workaround branch instruction overflow in tcg_out_qemu_ld/st (2018-05-01 11:56:55 -0700)
>
> ----------------------------------------------------------------
> Queued TCG patches
>

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Peter Maydell]

On 23 February 2016 at 16:14, Richard Henderson <rth@twiddle.net> wrote:
> On 02/15/2016 05:04 AM, Peter Maydell wrote:
>> This failed to build on the i686-w64-mingw32 compiler
>> ("i686-w64-mingw32-gcc (GCC) 4.8.2", from the Ubuntu
>> gcc-mingw-w64-i686 package version 4.8.2-10ubuntu2+12):
>>
>> target-sparc/translate.c: In function ‘gen_intermediate_code’:
>> target-sparc/translate.c:299:24: error: array subscript is above array
>> bounds [-Werror=array-bounds]
>>          return cpu_regs[reg];
>>                         ^
>>
>> Fiddling around with the source file to see which call to
>> gen_dest_gpr() is provoking this shows that it's the one
>> in gen_ldda_asi() at line 2157 -- if I change the second
>> argument from 'rd + 1' to 'rd' it compiles OK.
>
> Does it also work to change to "rd | 1"?

Yes, that seems to work too.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Richard Henderson]

On 02/15/2016 05:04 AM, Peter Maydell wrote:
> This failed to build on the i686-w64-mingw32 compiler
> ("i686-w64-mingw32-gcc (GCC) 4.8.2", from the Ubuntu
> gcc-mingw-w64-i686 package version 4.8.2-10ubuntu2+12):
> 
> target-sparc/translate.c: In function ‘gen_intermediate_code’:
> target-sparc/translate.c:299:24: error: array subscript is above array
> bounds [-Werror=array-bounds]
>          return cpu_regs[reg];
>                         ^
> 
> Fiddling around with the source file to see which call to
> gen_dest_gpr() is provoking this shows that it's the one
> in gen_ldda_asi() at line 2157 -- if I change the second
> argument from 'rd + 1' to 'rd' it compiles OK.

Does it also work to change to "rd | 1"?

I'd prefer to keep the change as local as possible, especially since I've got
another patch set pending that changes all of this code too.

> Changing the call site of gen_ldda_asi at line 4727 so its last
> argument is 'rd & ~1' rather than 'rd' also suppresses the
> error. (That can't possibly change the semantics because we've
> just done "if (rd & 1) goto illegal_insn;"...)


r~

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Peter Maydell]

On 23 February 2016 at 07:55, Richard Henderson <rth@twiddle.net> wrote:
> On 02/16/2016 03:45 AM, Peter Maydell wrote:
>>>
>>> Well, it doesn't repro on i686-linux; with a cross-compiler to mingw it
>>> still might, but filing the bug will save me setting up the full cross
>>> environment to be able to build qemu with mingw.
>>
>>
>> I started filing a bug, but the preprocessed source exceeds the 1MB
>> size limit on gcc bugzilla anyway. So I'm just going to put the
>> output of gcc -save-temps -v below, and you can find translate.i
>> at http://people.linaro.org/~peter.maydell/translate.i (2.3MB).
>
>
> While I can reproduce this with the ubuntu gcc 4.8.2 package, I cannot
> reproduce it with upstream source (which is currently at 4.8.5).
>
> I'm not going to spend any more time on this.  I guess you'd like the
> workaround?

Yes, please.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Richard Henderson]

On 02/16/2016 03:45 AM, Peter Maydell wrote:
>> Well, it doesn't repro on i686-linux; with a cross-compiler to mingw it
>> still might, but filing the bug will save me setting up the full cross
>> environment to be able to build qemu with mingw.
>
> I started filing a bug, but the preprocessed source exceeds the 1MB
> size limit on gcc bugzilla anyway. So I'm just going to put the
> output of gcc -save-temps -v below, and you can find translate.i
> at http://people.linaro.org/~peter.maydell/translate.i (2.3MB).

While I can reproduce this with the ubuntu gcc 4.8.2 package, I cannot 
reproduce it with upstream source (which is currently at 4.8.5).

I'm not going to spend any more time on this.  I guess you'd like the workaround?


r~

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Peter Maydell]

On 15 February 2016 at 20:35, Peter Maydell <peter.maydell@linaro.org> wrote:
> We should give it a try with Eric's "stop overriding
> 'inline' to mean 'always inline', but as you say
> with only one caller it's probably going to go ahead
> and inline it anyway.

...and indeed Eric's patch has no effect on this.

-- PMM

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Peter Maydell]

On 15 February 2016 at 20:57, Richard Henderson <rth@twiddle.net> wrote:
> On 02/16/2016 07:35 AM, Peter Maydell wrote:
>> On 15 February 2016 at 20:29, Richard Henderson <rth@twiddle.net> wrote:
>>> I couldn't reproduce this quickly with a freshly built gcc 4.8 branch on
>>> i686-linux.  Could you please file a gcc bug with your preprocessed
>>> source?
>>> There's a chance it isn't a duplicate, but...
>>
>>
>> Is it worth filing a bug that only repros on a non-upstream gcc?
>
>
> Well, it doesn't repro on i686-linux; with a cross-compiler to mingw it
> still might, but filing the bug will save me setting up the full cross
> environment to be able to build qemu with mingw.

I started filing a bug, but the preprocessed source exceeds the 1MB
size limit on gcc bugzilla anyway. So I'm just going to put the
output of gcc -save-temps -v below, and you can find translate.i
at http://people.linaro.org/~peter.maydell/translate.i (2.3MB).


$ i686-w64-mingw32-gcc -I/home/petmay01/linaro/qemu-for-merges/tcg
-I/home/petmay01/linaro/qemu-for-merges/tcg/i386 -I.
-I/home/petmay01/linaro/qemu-for-merges
-I/home/petmay01/linaro/qemu-for-merges/include
-I/home/petmay01/linaro/qemu-for-merges/target-sparc -Itarget-sparc
-I/home/petmay01/linaro/mingw/include/pixman-1
-I/home/petmay01/linaro/qemu-for-merges/dtc/libfdt -m32 -mthreads
-D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501
-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings
-Wmissing-prototypes -fno-strict-aliasing -fno-common
-I/home/petmay01/linaro/mingw/include  -Wno-unused-local-typedefs
-Werror -Wendif-labels -Wmissing-include-dirs -Wempty-body
-Wnested-externs -Wformat-security -Wformat-y2k -Winit-self
-Wignored-qualifiers -Wold-style-declaration -Wold-style-definition
-Wtype-limits -fstack-protector-all
-I/home/petmay01/linaro/mingw/include/libpng15    -I..
-I/home/petmay01/linaro/qemu-for-merges/target-sparc -DNEED_CPU_H
-I/home/petmay01/linaro/qemu-for-merges/include  -MMD -MP -MT
target-sparc/translate.o -MF target-sparc/translate.d -O2
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -mms-bitfields
-I/home/petmay01/linaro/mingw/include/glib-2.0
-I/home/petmay01/linaro/mingw/lib/glib-2.0/include   -g   -c -o
target-sparc/translate.o
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c
-save-temps -v
Using built-in specs.
COLLECT_GCC=i686-w64-mingw32-gcc
Target: i686-w64-mingw32
Configured with: ../../src/configure --build=x86_64-linux-gnu
--prefix=/usr --includedir='/usr/include' --mandir='/usr/share/man'
--infodir='/usr/share/info' --sysconfdir=/etc --localstatedir=/var
--libexecdir='/usr/lib/gcc-mingw-w64' --disable-maintainer-mode
--disable-dependency-tracking --prefix=/usr --enable-shared
--enable-static --disable-multilib --with-system-zlib
--libexecdir=/usr/lib --without-included-gettext --libdir=/usr/lib
--enable-libstdcxx-time=yes --with-tune=generic
--enable-version-specific-runtime-libs --enable-threads=posix
--enable-fully-dynamic-string --enable-sjlj-exceptions
--enable-libgomp --enable-languages=c,c++,fortran,objc,obj-c++
--enable-lto --with-plugin-ld --target=i686-w64-mingw32
--with-gxx-include-dir=/usr/include/c++/4.8
--with-as=/usr/bin/i686-w64-mingw32-as
--with-ld=/usr/bin/i686-w64-mingw32-ld
Thread model: posix
gcc version 4.8.2 (GCC)
COLLECT_GCC_OPTIONS='-I' '/home/petmay01/linaro/qemu-for-merges/tcg'
'-I' '/home/petmay01/linaro/qemu-for-merges/tcg/i386' '-I' '.' '-I'
'/home/petmay01/linaro/qemu-for-merges' '-I'
'/home/petmay01/linaro/qemu-for-merges/include' '-I'
'/home/petmay01/linaro/qemu-for-merges/target-sparc' '-I'
'target-sparc' '-I' '/home/petmay01/linaro/mingw/include/pixman-1'
'-I' '/home/petmay01/linaro/qemu-for-merges/dtc/libfdt' '-m32'
'-mthreads' '-D' '__USE_MINGW_ANSI_STDIO=1' '-D' 'WIN32_LEAN_AND_MEAN'
'-D' 'WINVER=0x501' '-D' '_GNU_SOURCE' '-D' '_FILE_OFFSET_BITS=64'
'-D' '_LARGEFILE_SOURCE' '-Wstrict-prototypes' '-Wredundant-decls'
'-Wall' '-Wundef' '-Wwrite-strings' '-Wmissing-prototypes'
'-fno-strict-aliasing' '-fno-common' '-I'
'/home/petmay01/linaro/mingw/include' '-Wno-unused-local-typedefs'
'-Werror' '-Wendif-labels' '-Wmissing-include-dirs' '-Wempty-body'
'-Wnested-externs' '-Wformat-security' '-Wformat-y2k' '-Winit-self'
'-Wignored-qualifiers' '-Wold-style-declaration'
'-Wold-style-definition' '-Wtype-limits' '-fstack-protector-all' '-I'
'/home/petmay01/linaro/mingw/include/libpng15' '-I' '..' '-I'
'/home/petmay01/linaro/qemu-for-merges/target-sparc' '-D' 'NEED_CPU_H'
'-I' '/home/petmay01/linaro/qemu-for-merges/include' '-MMD' '-MP'
'-MT' 'target-sparc/translate.o' '-MF' 'target-sparc/translate.d'
'-O2' '-U' '_FORTIFY_SOURCE' '-D' '_FORTIFY_SOURCE=2' '-mms-bitfields'
'-I' '/home/petmay01/linaro/mingw/include/glib-2.0' '-I'
'/home/petmay01/linaro/mingw/lib/glib-2.0/include' '-g' '-c' '-o'
'target-sparc/translate.o' '-save-temps' '-v' '-mtune=generic'
'-march=pentiumpro'
 /usr/lib/gcc/i686-w64-mingw32/4.8/cc1 -E -quiet -v -I
/home/petmay01/linaro/qemu-for-merges/tcg -I
/home/petmay01/linaro/qemu-for-merges/tcg/i386 -I . -I
/home/petmay01/linaro/qemu-for-merges -I
/home/petmay01/linaro/qemu-for-merges/include -I
/home/petmay01/linaro/qemu-for-merges/target-sparc -I target-sparc -I
/home/petmay01/linaro/mingw/include/pixman-1 -I
/home/petmay01/linaro/qemu-for-merges/dtc/libfdt -I
/home/petmay01/linaro/mingw/include -I
/home/petmay01/linaro/mingw/include/libpng15 -I .. -I
/home/petmay01/linaro/qemu-for-merges/target-sparc -I
/home/petmay01/linaro/qemu-for-merges/include -I
/home/petmay01/linaro/mingw/include/glib-2.0 -I
/home/petmay01/linaro/mingw/lib/glib-2.0/include -MMD
target-sparc/translate.d -MF target-sparc/translate.d -MP -MT
target-sparc/translate.o -D_MT -D_REENTRANT -D
__USE_MINGW_ANSI_STDIO=1 -D WIN32_LEAN_AND_MEAN -D WINVER=0x501 -D
_GNU_SOURCE -D _FILE_OFFSET_BITS=64 -D _LARGEFILE_SOURCE -D NEED_CPU_H
-U _FORTIFY_SOURCE -D _FORTIFY_SOURCE=2
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c -m32
-mthreads -mms-bitfields -mtune=generic -march=pentiumpro
-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings
-Wmissing-prototypes -Wno-unused-local-typedefs -Werror -Wendif-labels
-Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration
-Wold-style-definition -Wtype-limits -fno-strict-aliasing -fno-common
-fstack-protector-all -g -fworking-directory -O2 -fpch-preprocess -o
translate.i
ignoring nonexistent directory
"/usr/lib/gcc/i686-w64-mingw32/4.8/../../../../i686-w64-mingw32/sys-include"
ignoring duplicate directory
"/home/petmay01/linaro/qemu-for-merges/target-sparc"
ignoring duplicate directory "/home/petmay01/linaro/qemu-for-merges/include"
#include "..." search starts here:
#include <...> search starts here:
 /home/petmay01/linaro/qemu-for-merges/tcg
 /home/petmay01/linaro/qemu-for-merges/tcg/i386
 .
 /home/petmay01/linaro/qemu-for-merges
 /home/petmay01/linaro/qemu-for-merges/include
 /home/petmay01/linaro/qemu-for-merges/target-sparc
 target-sparc
 /home/petmay01/linaro/mingw/include/pixman-1
 /home/petmay01/linaro/qemu-for-merges/dtc/libfdt
 /home/petmay01/linaro/mingw/include
 /home/petmay01/linaro/mingw/include/libpng15
 ..
 /home/petmay01/linaro/mingw/include/glib-2.0
 /home/petmay01/linaro/mingw/lib/glib-2.0/include
 /usr/lib/gcc/i686-w64-mingw32/4.8/include
 /usr/lib/gcc/i686-w64-mingw32/4.8/include-fixed
 /usr/lib/gcc/i686-w64-mingw32/4.8/../../../../i686-w64-mingw32/include
End of search list.
COLLECT_GCC_OPTIONS='-I' '/home/petmay01/linaro/qemu-for-merges/tcg'
'-I' '/home/petmay01/linaro/qemu-for-merges/tcg/i386' '-I' '.' '-I'
'/home/petmay01/linaro/qemu-for-merges' '-I'
'/home/petmay01/linaro/qemu-for-merges/include' '-I'
'/home/petmay01/linaro/qemu-for-merges/target-sparc' '-I'
'target-sparc' '-I' '/home/petmay01/linaro/mingw/include/pixman-1'
'-I' '/home/petmay01/linaro/qemu-for-merges/dtc/libfdt' '-m32'
'-mthreads' '-D' '__USE_MINGW_ANSI_STDIO=1' '-D' 'WIN32_LEAN_AND_MEAN'
'-D' 'WINVER=0x501' '-D' '_GNU_SOURCE' '-D' '_FILE_OFFSET_BITS=64'
'-D' '_LARGEFILE_SOURCE' '-Wstrict-prototypes' '-Wredundant-decls'
'-Wall' '-Wundef' '-Wwrite-strings' '-Wmissing-prototypes'
'-fno-strict-aliasing' '-fno-common' '-I'
'/home/petmay01/linaro/mingw/include' '-Wno-unused-local-typedefs'
'-Werror' '-Wendif-labels' '-Wmissing-include-dirs' '-Wempty-body'
'-Wnested-externs' '-Wformat-security' '-Wformat-y2k' '-Winit-self'
'-Wignored-qualifiers' '-Wold-style-declaration'
'-Wold-style-definition' '-Wtype-limits' '-fstack-protector-all' '-I'
'/home/petmay01/linaro/mingw/include/libpng15' '-I' '..' '-I'
'/home/petmay01/linaro/qemu-for-merges/target-sparc' '-D' 'NEED_CPU_H'
'-I' '/home/petmay01/linaro/qemu-for-merges/include' '-MMD' '-MP'
'-MT' 'target-sparc/translate.o' '-MF' 'target-sparc/translate.d'
'-O2' '-U' '_FORTIFY_SOURCE' '-D' '_FORTIFY_SOURCE=2' '-mms-bitfields'
'-I' '/home/petmay01/linaro/mingw/include/glib-2.0' '-I'
'/home/petmay01/linaro/mingw/lib/glib-2.0/include' '-g' '-c' '-o'
'target-sparc/translate.o' '-save-temps' '-v' '-mtune=generic'
'-march=pentiumpro'
 /usr/lib/gcc/i686-w64-mingw32/4.8/cc1 -fpreprocessed translate.i
-quiet -dumpbase translate.c -m32 -mthreads -mms-bitfields
-mtune=generic -march=pentiumpro -auxbase-strip
target-sparc/translate.o -g -O2 -Wstrict-prototypes -Wredundant-decls
-Wall -Wundef -Wwrite-strings -Wmissing-prototypes
-Wno-unused-local-typedefs -Werror -Wendif-labels
-Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration
-Wold-style-definition -Wtype-limits -version -fno-strict-aliasing
-fno-common -fstack-protector-all -o translate.s
GNU C (GCC) version 4.8.2 (i686-w64-mingw32)
        compiled by GNU C version 4.8.2, GMP version 5.1.2, MPFR
version 3.1.2-p3, MPC version 1.0.1
warning: GMP header version 5.1.2 differs from library version 5.1.3.
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
GNU C (GCC) version 4.8.2 (i686-w64-mingw32)
        compiled by GNU C version 4.8.2, GMP version 5.1.2, MPFR
version 3.1.2-p3, MPC version 1.0.1
warning: GMP header version 5.1.2 differs from library version 5.1.3.
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: c03a50cdfea1ac209c791d80ef4799a8
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c: In
function ‘gen_intermediate_code’:
/home/petmay01/linaro/qemu-for-merges/target-sparc/translate.c:299:24:
error: array subscript is above array bounds [-Werror=array-bounds]
         return cpu_regs[reg];
                        ^
cc1: all warnings being treated as errors

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Richard Henderson]

On 02/16/2016 07:35 AM, Peter Maydell wrote:
> On 15 February 2016 at 20:29, Richard Henderson <rth@twiddle.net> wrote:
>> On 02/16/2016 12:04 AM, Peter Maydell wrote:
>>> I'm generally reluctant to suggest compiler bugs, but this does
>>> look rather like a compiler bug...
>>
>>
>> There are at least 5 such bugs open against gcc at the moment.
>>
>>      https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56456
>>
>> I couldn't reproduce this quickly with a freshly built gcc 4.8 branch on
>> i686-linux.  Could you please file a gcc bug with your preprocessed source?
>> There's a chance it isn't a duplicate, but...
>
> Is it worth filing a bug that only repros on a non-upstream gcc?

Well, it doesn't repro on i686-linux; with a cross-compiler to mingw it still 
might, but filing the bug will save me setting up the full cross environment to 
be able to build qemu with mingw.



r~

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Peter Maydell]

On 15 February 2016 at 20:29, Richard Henderson <rth@twiddle.net> wrote:
> On 02/16/2016 12:04 AM, Peter Maydell wrote:
>> I'm generally reluctant to suggest compiler bugs, but this does
>> look rather like a compiler bug...
>
>
> There are at least 5 such bugs open against gcc at the moment.
>
>     https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56456
>
> I couldn't reproduce this quickly with a freshly built gcc 4.8 branch on
> i686-linux.  Could you please file a gcc bug with your preprocessed source?
> There's a chance it isn't a duplicate, but...

Is it worth filing a bug that only repros on a non-upstream gcc?

> In the meantime... hmm.  I don't suppose removing the inline helps?
> Probably not, since there's only one caller...  Otherwise I guess we should
> go with your "rd & ~1" workaround.

We should give it a try with Eric's "stop overriding
'inline' to mean 'always inline', but as you say
with only one caller it's probably going to go ahead
and inline it anyway.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Richard Henderson]

On 02/16/2016 12:04 AM, Peter Maydell wrote:
> On 15 February 2016 at 11:29, Richard Henderson <rth@twiddle.net> wrote:
>> ----------------------------------------------------------------
>> Richard Henderson (5):
>>        tcg: Work around clang bug wrt enum ranges, part 2
>>        tcg: Implement indirect memory registers
>>        tcg: Allocate indirect_base temporaries in a different order
>>        target-sparc: Tidy global register initialization
>>        target-sparc: Use global registers for the register window
>>
>>   target-sparc/translate.c | 196 ++++++++++++++++++++++-------------------------
>>   tcg/tcg.c                | 138 +++++++++++++++++++++++----------
>>   tcg/tcg.h                |   2 +
>>   3 files changed, 192 insertions(+), 144 deletions(-)
>
> This failed to build on the i686-w64-mingw32 compiler
> ("i686-w64-mingw32-gcc (GCC) 4.8.2", from the Ubuntu
> gcc-mingw-w64-i686 package version 4.8.2-10ubuntu2+12):
>
> target-sparc/translate.c: In function ‘gen_intermediate_code’:
> target-sparc/translate.c:299:24: error: array subscript is above array
> bounds [-Werror=array-bounds]
>           return cpu_regs[reg];
>                          ^
>
> Fiddling around with the source file to see which call to
> gen_dest_gpr() is provoking this shows that it's the one
> in gen_ldda_asi() at line 2157 -- if I change the second
> argument from 'rd + 1' to 'rd' it compiles OK.
>
> Changing the call site of gen_ldda_asi at line 4727 so its last
> argument is 'rd & ~1' rather than 'rd' also suppresses the
> error. (That can't possibly change the semantics because we've
> just done "if (rd & 1) goto illegal_insn;"...)
>
> I'm generally reluctant to suggest compiler bugs, but this does
> look rather like a compiler bug...

There are at least 5 such bugs open against gcc at the moment.

     https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56456

I couldn't reproduce this quickly with a freshly built gcc 4.8 branch on 
i686-linux.  Could you please file a gcc bug with your preprocessed source? 
There's a chance it isn't a duplicate, but...

In the meantime... hmm.  I don't suppose removing the inline helps?  Probably 
not, since there's only one caller...  Otherwise I guess we should go with your 
"rd & ~1" workaround.


r~

Re: [Qemu-devel] [PULL 0/5] tcg queued patches

[Peter Maydell]

On 15 February 2016 at 11:29, Richard Henderson <rth@twiddle.net> wrote:
> ----------------------------------------------------------------
> Richard Henderson (5):
>       tcg: Work around clang bug wrt enum ranges, part 2
>       tcg: Implement indirect memory registers
>       tcg: Allocate indirect_base temporaries in a different order
>       target-sparc: Tidy global register initialization
>       target-sparc: Use global registers for the register window
>
>  target-sparc/translate.c | 196 ++++++++++++++++++++++-------------------------
>  tcg/tcg.c                | 138 +++++++++++++++++++++++----------
>  tcg/tcg.h                |   2 +
>  3 files changed, 192 insertions(+), 144 deletions(-)

This failed to build on the i686-w64-mingw32 compiler
("i686-w64-mingw32-gcc (GCC) 4.8.2", from the Ubuntu
gcc-mingw-w64-i686 package version 4.8.2-10ubuntu2+12):

target-sparc/translate.c: In function ‘gen_intermediate_code’:
target-sparc/translate.c:299:24: error: array subscript is above array
bounds [-Werror=array-bounds]
         return cpu_regs[reg];
                        ^

Fiddling around with the source file to see which call to
gen_dest_gpr() is provoking this shows that it's the one
in gen_ldda_asi() at line 2157 -- if I change the second
argument from 'rd + 1' to 'rd' it compiles OK.

Changing the call site of gen_ldda_asi at line 4727 so its last
argument is 'rd & ~1' rather than 'rd' also suppresses the
error. (That can't possibly change the semantics because we've
just done "if (rd & 1) goto illegal_insn;"...)

I'm generally reluctant to suggest compiler bugs, but this does
look rather like a compiler bug...

thanks
-- PMM

[Qemu-devel] [PULL 0/5] tcg queued patches

[Richard Henderson]

One clang fix and the improvments for sparc register windows.


r~



The following changes since commit a5af12871fd4601c44f08d9e49131e9ca13ef102:

  Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2016-02-12' into staging (2016-02-12 17:36:12 +0000)

are available in the git repository at:

  git://github.com/rth7680/qemu.git tags/pull-tcg-20160215

for you to fetch changes up to dcf640230d5c4779c8b31a97ab130ac183b965a0:

  target-sparc: Use global registers for the register window (2016-02-15 22:27:08 +1100)

----------------------------------------------------------------
Clang fix and Sparc improvements

----------------------------------------------------------------
Richard Henderson (5):
      tcg: Work around clang bug wrt enum ranges, part 2
      tcg: Implement indirect memory registers
      tcg: Allocate indirect_base temporaries in a different order
      target-sparc: Tidy global register initialization
      target-sparc: Use global registers for the register window

 target-sparc/translate.c | 196 ++++++++++++++++++++++-------------------------
 tcg/tcg.c                | 138 +++++++++++++++++++++++----------
 tcg/tcg.h                |   2 +
 3 files changed, 192 insertions(+), 144 deletions(-)