From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh6df-0001Ta-BM for qemu-devel@nongnu.org; Tue, 19 Jun 2012 18:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sh6dd-0002FU-LM for qemu-devel@nongnu.org; Tue, 19 Jun 2012 18:11:06 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:50915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh6dd-0002Er-Ej for qemu-devel@nongnu.org; Tue, 19 Jun 2012 18:11:05 -0400 Received: by bkwj10 with SMTP id j10so5963475bkw.4 for ; Tue, 19 Jun 2012 15:11:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4FE0F4B8.7020603@freescale.com> References: <20120619023136.GA5187@tyr.buserror.net> <4FE013E3.6090907@weilnetz.de> <4FE0F4B8.7020603@freescale.com> Date: Tue, 19 Jun 2012 23:11:02 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Wood Cc: Blue Swirl , Stefan Weil , qemu-devel@nongnu.org On 19 June 2012 22:52, Scott Wood wrote: > On 06/19/2012 12:53 AM, Stefan Weil wrote: >> I saw from git history that ppc once had the same bug. >> The sparc backend (and maybe others) might still have it. > > SPARC looks wrong; the others look OK as far as I can tell from a quick > glance, without being familiar with all of the architectures. Agreed. I think we fixed most of the others as part of avoiding problems with cache incoherency if you write the branch offset as zero and then rewrite it with the right target at reloc time. -- PMM