From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0AiL-00006w-9q for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:31:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0AiF-00022T-8w for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:31:49 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:36464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0AiF-00022N-2u for qemu-devel@nongnu.org; Thu, 26 Jun 2014 10:31:43 -0400 Received: by mail-lb0-f173.google.com with SMTP id s7so3007591lbd.18 for ; Thu, 26 Jun 2014 07:31:41 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1403355502-12288-8-git-send-email-pbonzini@redhat.com> References: <1403355502-12288-1-git-send-email-pbonzini@redhat.com> <1403355502-12288-8-git-send-email-pbonzini@redhat.com> From: Peter Maydell Date: Thu, 26 Jun 2014 15:31:21 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v3 07/11] target-arm: pass DisasContext to gen_aa32_ld*/st* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: QEMU Developers On 21 June 2014 13:58, Paolo Bonzini wrote: > We'll need the DisasContext in the next patch to retrieve the > desired endianness, so pass it as a whole to gen_aa32_ld*/st*. > > Unfortunately we cannot let those functions call get_mem_index, > because of user-mode load/store instructions. > > Signed-off-by: Paolo Bonzini This pushes some lines over 80 columns; can you wrap those, please? Otherwise Reviewed-by: Peter Maydell -- PMM