From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Maydell Subject: Re: [PATCH 4/4] kvm: i386: Add classic PCI device assignment Date: Tue, 28 Aug 2012 22:26:55 +0100 Message-ID: References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <503B64D9.4000708@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Alex Williamson , qemu-ppc , Avi Kivity , =?UTF-8?Q?Andreas_F=C3=A4rber?= To: Jan Kiszka Return-path: In-Reply-To: <503B64D9.4000708@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 27 August 2012 13:15, Jan Kiszka wrote: > On 2012-08-27 14:07, Andreas F=C3=A4rber wrote: >> Am I correct to understand we compile this only for i386 / x86_64? > > This is correct. Did we ever make a decision about whether architecture specific KVM devices should all live in hw/kvm/ or in some directory with the arch name in it? I guess they're all in hw/kvm/ at the moment so they should stay there unless there's a pressing reason to move them around... Since this is arch-specific we should probably give the resulting device a more specific name than "pci-assign", which implies that it is (a) ok for any PCI system and (b) not something that will be obsolete in the foreseen future. -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6TJK-0002uE-28 for qemu-devel@nongnu.org; Tue, 28 Aug 2012 17:26:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6TJJ-0003SI-23 for qemu-devel@nongnu.org; Tue, 28 Aug 2012 17:26:57 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:51777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6TJI-0003S4-TR for qemu-devel@nongnu.org; Tue, 28 Aug 2012 17:26:56 -0400 Received: by iakx26 with SMTP id x26so11222427iak.4 for ; Tue, 28 Aug 2012 14:26:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <503B64D9.4000708@siemens.com> References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503B62F4.9070500@suse.de> <503B64D9.4000708@siemens.com> Date: Tue, 28 Aug 2012 22:26:55 +0100 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , Alexey Kardashevskiy , Marcelo Tosatti , qemu-devel@nongnu.org, Alex Williamson , qemu-ppc , Avi Kivity , =?UTF-8?Q?Andreas_F=C3=A4rber?= On 27 August 2012 13:15, Jan Kiszka wrote: > On 2012-08-27 14:07, Andreas F=C3=A4rber wrote: >> Am I correct to understand we compile this only for i386 / x86_64? > > This is correct. Did we ever make a decision about whether architecture specific KVM devices should all live in hw/kvm/ or in some directory with the arch name in it? I guess they're all in hw/kvm/ at the moment so they should stay there unless there's a pressing reason to move them around... Since this is arch-specific we should probably give the resulting device a more specific name than "pci-assign", which implies that it is (a) ok for any PCI system and (b) not something that will be obsolete in the foreseen future. -- PMM