All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
	"Marcin Krzemiński" <mar.krzeminski@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3] [i.MX] Remove MSGDATA register support.
Date: Mon, 9 Jan 2017 11:56:23 +0000	[thread overview]
Message-ID: <CAFEAcA9fRh=MteBdYAxrgGWADovA4tTa4gNmOsfVbCnYggnRVw@mail.gmail.com> (raw)
In-Reply-To: <20170107122047.26300-1-jcd@tribudubois.net>

On 7 January 2017 at 12:20, Jean-Christophe Dubois <jcd@tribudubois.net> wrote:
> From the documentation it is not clear what this SPI register is about.
>
> Moreover, neither linux driver nor xvisor driver are using this SPI register.
>
> For now we just remove it and issue a log on register write access.

By the way, could you make sure you use standard commit subject
line forms like
 hw/spi/imx_spi.c: Remove ...

If you put [i.MX] in square brackets like that then patch application
tools remove it (on the assumption that it's a meta-tag like [PATCH])
and the commit summary in git ends up just "Remove MSGDATA register support"
with no indication of what bit of the code it is dealing with.

(I fixed up these two patches manually when I put them into target-arm.)

thanks
-- PMM

  parent reply	other threads:[~2017-01-09 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-07 12:20 [Qemu-devel] [PATCH v3] [i.MX] Remove MSGDATA register support Jean-Christophe Dubois
2017-01-09 11:00 ` Peter Maydell
2017-01-09 11:56 ` Peter Maydell [this message]
2017-01-09 15:12   ` jcd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9fRh=MteBdYAxrgGWADovA4tTa4gNmOsfVbCnYggnRVw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=jcd@tribudubois.net \
    --cc=mar.krzeminski@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.