All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/3] target/arm: Convert Neon 3-same-fp size field to MO_* in decode
Date: Thu, 3 Sep 2020 19:14:32 +0100	[thread overview]
Message-ID: <CAFEAcA9g-EZpqj2Qg4izL0YhteJB+7MiPcKWtO3QOXjn3a6cpw@mail.gmail.com> (raw)
In-Reply-To: <d4329a97-d20b-f47a-ddca-cc42cb190ee7@linaro.org>

On Thu, 3 Sep 2020 at 17:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 9/3/20 6:32 AM, Peter Maydell wrote:
> > I wanted to call the field %3same_fp_size, but decodetree
> > doesn't seem to allow a field starting with a digit, even
> > though it does allow a format that starts with a digit.
> > So it's %fp_3same_size...
>
> Odd.  All of the names get prefixed, so we don't have a problem of a digit
> beginning a C identifier...  I can look at fixing this if you want.

If it's not too involved a fix it would be nice. The failure
is that it doesn't manage to parse the file, rather than
that it produces bad code.

thanks
-- PMM


  reply	other threads:[~2020-09-03 18:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 13:32 [PATCH 0/3] target/arm: Decode Neon fp sizes in decodetree Peter Maydell
2020-09-03 13:32 ` [PATCH 1/3] target/arm: Convert Neon 3-same-fp size field to MO_* in decode Peter Maydell
2020-09-03 16:25   ` Richard Henderson
2020-09-03 18:14     ` Peter Maydell [this message]
2020-09-03 13:32 ` [PATCH 2/3] target/arm: Convert Neon VCVT fp " Peter Maydell
2020-09-03 16:27   ` Richard Henderson
2020-09-03 13:32 ` [PATCH 3/3] target/arm: Convert VCMLA, VCADD " Peter Maydell
2020-09-03 16:32   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9g-EZpqj2Qg4izL0YhteJB+7MiPcKWtO3QOXjn3a6cpw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.