From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amq3F-0003zj-DS for qemu-devel@nongnu.org; Sun, 03 Apr 2016 17:59:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amq3E-0002Vz-JS for qemu-devel@nongnu.org; Sun, 03 Apr 2016 17:59:21 -0400 Received: from mail-vk0-x234.google.com ([2607:f8b0:400c:c05::234]:35636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amq3E-0002Vv-Dh for qemu-devel@nongnu.org; Sun, 03 Apr 2016 17:59:20 -0400 Received: by mail-vk0-x234.google.com with SMTP id e6so159021396vkh.2 for ; Sun, 03 Apr 2016 14:59:20 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <3F266835-BBA7-4F79-94A6-B23788577069@livius.net> References: <0F59BEF3-8BDD-434B-9EC4-3DECF9465A44@livius.net> <63AEB8A6-929B-48B2-B6D1-13FC80F8888F@livius.net> <3F266835-BBA7-4F79-94A6-B23788577069@livius.net> From: Peter Maydell Date: Sun, 3 Apr 2016 22:59:00 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] segmentation fault in object.c:type_initialize_interface() if interface not defined List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liviu Ionescu Cc: QEMU Developers On 3 April 2016 at 22:42, Liviu Ionescu wrote: >> On 04 Apr 2016, at 00:30, Peter Maydell wrote: >> Which I completely agree with. If you want to send a patch >> to add the assert I'm happy to review it. > > I guess the original report was clear enough for an active commiter > to easily understand the problem and fix it, in significantly less > iterations that I would need to produce a compliant and acceptable > patch (reaching this point already took 9 messages). :-( There are many many bits of suboptimal code, things that could be improved and outright bugs in QEMU. Fixing any of them takes time, which is why as an open source project we encourage people to contribute the fixes they personally run into and find they need. (This is pretty much what anybody who is an active committer is already doing.) thanks -- PMM