From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLYpd-0000Zb-Vd for qemu-devel@nongnu.org; Tue, 19 Jan 2016 11:08:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLYpc-0000t8-4C for qemu-devel@nongnu.org; Tue, 19 Jan 2016 11:08:32 -0500 Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:34020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLYpa-0000sP-UW for qemu-devel@nongnu.org; Tue, 19 Jan 2016 11:08:32 -0500 Received: by mail-vk0-x22c.google.com with SMTP id e185so11521067vkb.1 for ; Tue, 19 Jan 2016 08:08:30 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <5258352497f088c6ef964f2a30ed1c87a7ecad88.1453100525.git.crosthwaite.peter@gmail.com> References: <5258352497f088c6ef964f2a30ed1c87a7ecad88.1453100525.git.crosthwaite.peter@gmail.com> From: Peter Maydell Date: Tue, 19 Jan 2016 16:08:10 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v1 05/17] target-arm: pass DisasContext to gen_aa32_ld*/st* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Crosthwaite , QEMU Developers , Alistair Francis , sridhar kulkarni , qemu-arm , Paolo Bonzini , =?UTF-8?Q?Piotr_Kr=C3=B3l?= On 18 January 2016 at 07:12, Peter Crosthwaite wrote: > From: Paolo Bonzini > > We'll need the DisasContext in the next patch to retrieve the > desired endianness, so pass it as a whole to gen_aa32_ld*/st*. > > Unfortunately we cannot let those functions call get_mem_index, > because of user-mode load/store instructions. > > Signed-off-by: Paolo Bonzini > [ PC changes: > * Fix long lines > ] > Signed-off-by: Peter Crosthwaite > --- Reviewed-by: Peter Maydell thanks -- PMM