From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as9vG-00021f-UK for qemu-devel@nongnu.org; Mon, 18 Apr 2016 10:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1as9vG-0002uR-6N for qemu-devel@nongnu.org; Mon, 18 Apr 2016 10:13:06 -0400 Received: from mail-vk0-x22e.google.com ([2607:f8b0:400c:c05::22e]:36851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as9vG-0002ty-1q for qemu-devel@nongnu.org; Mon, 18 Apr 2016 10:13:06 -0400 Received: by mail-vk0-x22e.google.com with SMTP id c4so221389821vkb.3 for ; Mon, 18 Apr 2016 07:13:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <871t63c994.fsf@dusky.pond.sub.org> References: <1460147350-7601-1-git-send-email-pbonzini@redhat.com> <1460147350-7601-40-git-send-email-pbonzini@redhat.com> <871t63c994.fsf@dusky.pond.sub.org> From: Peter Maydell Date: Mon, 18 Apr 2016 15:12:46 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH 39/50] gdbstub: remove includes from gdbstub-xml.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , QEMU Developers On 18 April 2016 at 14:54, Markus Armbruster wrote: > Paolo Bonzini writes: > >> gdbstub-xml.c defines a bunch of arrays of strings; there is no >> need to include anything. > We might want to include osdep.h anyway, just to avoid adding an > exception to the rule "any C file must include qemu/osdep.h first." Yes, I think we should be consistent there. thanks -- PMM