From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SqnPD-0003pP-TL
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:40:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SqnP7-0000tS-4l
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:40:15 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:37200)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1SqnP6-0000st-UW
	for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:40:09 -0400
Received: by bkcji1 with SMTP id ji1so3939438bkc.4
	for <qemu-devel@nongnu.org>; Mon, 16 Jul 2012 08:40:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <500434C8.6050200@redhat.com>
References: <1342360440-14328-1-git-send-email-sw@weilnetz.de>
	<500434C8.6050200@redhat.com>
Date: Mon, 16 Jul 2012 16:40:07 +0100
Message-ID: <CAFEAcA9hMiV-yB8QRJMG+N5fKSGohMNFf4nv3zXjKV3L4HBbHQ@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] configure: Fix build with capabilities
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On 16 July 2012 16:35, Eric Blake <eblake@redhat.com> wrote:
> On 07/15/2012 07:54 AM, Stefan Weil wrote:
>> Since commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests
>> normally run with -Werror. Some of these tests now fail because they
>> raised a compiler warning.

> Nothing wrong with this patch, per se, but in the Autoconf world, the
> general advice is that programs should check whether -Werror is
> supported, but then avoid using it for the entire remainder of the
> configure script (that is, store the result of -Werror into a different
> variable that gets added into the final CFLAGS at make time, but not
> used during any of the rest of the configure time).  That's because it's
> just too hard to avoid warnings-turned-into-errors for all possible
> versions (including future releases) of gcc, so you are just too likely
> to run into spurious changes in configurations when the next version of
> gcc starts warning about something new if you try to run all your
> configure tests with -Werror.

Hmm, good point -- unlike the actual program compile, failures
due to -Werror inside configure are silent and near-invisible.
Maybe we should back out 417c9d72 ?

-- PMM