From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6yj2-0006vF-Tw for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:45:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6yj1-0003iB-Vl for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:45:28 -0500 Received: from mail-vk0-x22a.google.com ([2607:f8b0:400c:c05::22a]:35103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6yj1-0003hs-MM for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:45:27 -0500 Received: by vkha189 with SMTP id a189so77126982vkh.2 for ; Thu, 10 Dec 2015 02:45:27 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1449743372-17169-2-git-send-email-armbru@redhat.com> References: <1449743372-17169-1-git-send-email-armbru@redhat.com> <1449743372-17169-2-git-send-email-armbru@redhat.com> From: Peter Maydell Date: Thu, 10 Dec 2015 10:45:07 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH 01/12] hw: Don't use hw_error() for machine initialization errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Guan Xuetao , "qemu-ppc@nongnu.org" , QEMU Developers , qemu-arm , Richard Henderson On 10 December 2015 at 10:29, Markus Armbruster wrote: > Printing CPU registers is not helpful during machine initialization. > Moreover, these are straightforward configuration or "can get > resources" errors, so dumping core isn't appropriate either. Replace > hw_error() by error_report(); exit(1). Matches how we report these > errors in other machine initializations. > > Cc: Richard Henderson > Cc: qemu-arm@nongnu.org > Cc: qemu-ppc@nongnu.org > Cc: Guan Xuetao > Signed-off-by: Markus Armbruster > --- Reviewed-by: Peter Maydell thanks -- PMM