From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D012CC4361B for ; Thu, 17 Dec 2020 22:50:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CC9A23A24 for ; Thu, 17 Dec 2020 22:50:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CC9A23A24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kq26s-0006ub-0H for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 17:50:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kq25x-0006O8-KG for qemu-devel@nongnu.org; Thu, 17 Dec 2020 17:50:01 -0500 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:36575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kq25v-0006Ru-Ev for qemu-devel@nongnu.org; Thu, 17 Dec 2020 17:50:01 -0500 Received: by mail-ej1-x632.google.com with SMTP id lt17so444269ejb.3 for ; Thu, 17 Dec 2020 14:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FqhGn/YVfKuAoZNwt+7qlcIUVLsbRBpWgT9SVMGIODQ=; b=gG3g7b4Xjwbb35L/vvZ+sqmu3w8b8Ot9eClcOgLdMO1hxYi3CJBTotgUtBpbHfPv13 HUxKI9yfJ/Dtl0TiidPplUKrov1ZKxrIK6vTy+I+IVGxfwwAlYiXABOf+J3ecQxgacLe wxWkbTC+Mq4Tfne55OE7T/DYCxY0Tg7ZTuiJV7l3i0zNOmtXdwog31YgL7A1IfAybARx hMTbqxMI5yOXB1j6IzHjbk9/r6fnuupZ0KmkP4ku2PTNRO6OQ1FjkeDLF9WQmNsyscoZ 5vF6k4LgBl58TkrGw+9HdnpfsZS6ZFAkJL+bgWrSbaMrGN9Cw+jZJ6Oe0rM+Cbgx1UBk ZqaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FqhGn/YVfKuAoZNwt+7qlcIUVLsbRBpWgT9SVMGIODQ=; b=fKZT5rUFSzRZnKjugoTgwv6E4Qu/JRSKOMQGBUbrvMPVr4aHba/qza3myoJ5I62Ots +oLcinQctmvIxuIRoJ0L/U1sjmQKUxzQ1pBgXGIF6LvtjsGo7EKm7ge//0Ll3ZME5Hye PVjss0ZYa53z6AO+eEm9044JKHMvC3jX1/Upzr8rpOHQYfsaEoxmXSTQCnvgNdfZ1S4b zViQ2qpvlIv3brnbkvMn96Do5cklmaXfZ9Ke1qD68d4qTTDXPXqyk5yl38SRqJUme8yh j/jL+adM3Z3N2qvpvhXJCBJUlj937x7bJJh8tSDFOLHdrMOvDyPOQLWK9+p7kfrnuTVg ebIA== X-Gm-Message-State: AOAM530Jz5rQZoq3zt8SL0P/40dPFTMWqV9lAJVt8KGp2rlihDW+jzl9 Pe5YlD5EkwNP8F2CXyZGZvtxEpHyf4MuQf2bomYpGg== X-Google-Smtp-Source: ABdhPJyeCzgvoBEKoFdW0jTS/cVa8oeCXvHMlUobn+3wWHetd9FejqqaLD2kx1dy6kEEhsNaRx1CCW3anGIjSb2XkT0= X-Received: by 2002:a17:906:195a:: with SMTP id b26mr1292641eje.4.1608245396764; Thu, 17 Dec 2020 14:49:56 -0800 (PST) MIME-Version: 1.0 References: <20201211100908.19696-1-cfontana@suse.de> <20201211100908.19696-8-cfontana@suse.de> In-Reply-To: From: Peter Maydell Date: Thu, 17 Dec 2020 22:49:45 +0000 Message-ID: Subject: Re: dangers of current NEED_CPU_H, CONFIG_SOFTMMU, CONFIG_USER_ONLY To: Claudio Fontana Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Richard Henderson , QEMU Developers , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini , Alex Bennee Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 17 Dec 2020 at 22:45, Claudio Fontana wrote: > > On 12/17/20 9:15 PM, Peter Maydell wrote: > > On Thu, 17 Dec 2020 at 19:46, Claudio Fontana wrote: > > Yeah, don't try to ifdef out struct fields in common-compiled code... > > or should I? Using > > #ifdef NEED_CPU_H > #ifdef CONFIG_SOFTMMU > > seems to do what I expect. Is it wrong? I think that gives you two versions of the struct: - one seen by compiled-once files and by compiled-per-target softmmu files - one seen by compiled-per-target user-only files Since the user-only target executables link both compiled-per-target and compiled-once files I think they end up with different C files thinking the same struct has a different layout/size which seems like it's going to cause problems. thanks -- PMM