Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code

From: Peter Maydell <peter.maydell@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>,
	Olaf Hering <OHering@suse.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code
Date: Fri, 20 Jul 2012 13:30:22 +0100	[thread overview]
Message-ID: <CAFEAcA9jr0Aexb=htsUsMHxOp5ExXyaRYFqc0j_y_RzUmWn7dA@mail.gmail.com> (raw)
In-Reply-To: <50094EEA.6000801@suse.de>

On 20 July 2012 13:28, Andreas Färber <afaerber@suse.de> wrote:
> Am 17.07.2012 21:19, schrieb Peter Maydell:
>> On 17 July 2012 20:07, Stefan Weil <sw@weilnetz.de> wrote:
>>> If the user overrides CFLAGS, I expect that he/she will notice
>>> that compilation fails and hopefully find the cause (only
>>> expert users should override CFLAGS). Overriding -march=i486
>>> might be useful to set -march=i686.
>>>
>>> Therefore it was not so obvious to me whether CFLAGS or
>>> QEMU_CFLAGS was the better choice.
>>
>> Yes, I had to dig to find out the underlying principle
>> distinguishing the two. Having found it I would like us to
>> fix this in a way which respects that principle.
>
> I was planning to pick up Olaf's patch doing just that but haven't got
> around to it in time for v1.1. Olaf, do you have time to resubmit a
> patch to upstream qemu-devel as requested by Peter and me?

I actually wrote a patch sitting on top of this one by Stefan
which moves the flag to QEMU_CFLAGS;
both are in the 11-patch series dealing with various configure
Werror issues:
 http://patchwork.ozlabs.org/patch/171689/
 http://patchwork.ozlabs.org/patch/171706/

-- PMM