From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3DEFC433F5 for ; Wed, 6 Apr 2022 11:17:19 +0000 (UTC) Received: from localhost ([::1]:53604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nc3f4-0005kX-KS for qemu-devel@archiver.kernel.org; Wed, 06 Apr 2022 07:17:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nc3ch-0003v4-Ty for qemu-devel@nongnu.org; Wed, 06 Apr 2022 07:14:51 -0400 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]:39069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nc3cf-0008Iy-AC for qemu-devel@nongnu.org; Wed, 06 Apr 2022 07:14:51 -0400 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-2eb3db5b172so22147347b3.6 for ; Wed, 06 Apr 2022 04:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MkKxjYAV/v0VMd11SMXqG8EhXPeJQ34GzLrs6aLHBhk=; b=BnkL/xviW3/SATQQBN0J4jLUdrTQRMmZsVp7lEWCOmkmWwekK4I3vVJpW5wY+oaW6o wMWw7poztVXO8dmLd+4dn47QCBX/MLXDvtQ0FtncjF48Ky/apTe5LetGClF9I8xv8hLd 39QIq1nCVrCyq+b89tHhY+wy8NDABlDcruy0U3VUH+wy5CC/74PQNoqlWZUGpPI4ktd2 2syhOC3nTsaeBG0iofZAEy+fKLdo2YsKyo/Wo++rIt2NrTU9fzPbBH0Ng8KlfS5PTmtk EZZmtp49FjP3cappOUQR7sHOielNZL7XjaQF+GBy228W5SABlrjalbp+fGs0YWTIyb9y NQoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MkKxjYAV/v0VMd11SMXqG8EhXPeJQ34GzLrs6aLHBhk=; b=32uRKRJ0LWry0h+rj2HuAc3SD/Qx/YGoQogVzviYdNafUoEJzWddD/2pLHWEReu9mN H5hVZwfJ7RX5gbMsXicG3r0kbdFeG3yzTUpEcujPXyQOOoccSKAZgvjYvP6+RlwJhesA UYyDpRonbMfBOgwfUmDICTBi1eQr3hR1bkoGAh9991G8WPbbKFJeOwHV+DRWbHwzSFBu hMdJMCPcR+uhHGZF0JllsD5cjUwKrgTFyKyZUQKJtu4tl1s/cTcB5SvhWYFjZNDR+aO1 1dW6IDSH4LG9AFNXt4ma3Z0r0MHI9ywukSeEalNTlD+lZ8t5obIfgAOBhHIOaCf9vy0Z BXnA== X-Gm-Message-State: AOAM530qPGE/QusYaZq8JWbwpjFbNoO7OpWWElKwh33CmYAm8uRTrShX AbkKF8Bcbr0Jr9cX/UXXQfCMQEhMIwAiTy5SlGb04w== X-Google-Smtp-Source: ABdhPJytWaKSjrcKoa2mbzwJv7RhwFSgw11lPqUjgtEaNT3OmaJMCRA7mDMdyjLwii6p/gHggvStzLZXxV0l/YkXcmI= X-Received: by 2002:a81:1592:0:b0:2eb:5472:c681 with SMTP id 140-20020a811592000000b002eb5472c681mr6491648ywv.10.1649243687745; Wed, 06 Apr 2022 04:14:47 -0700 (PDT) MIME-Version: 1.0 References: <20220323155743.1585078-1-marcandre.lureau@redhat.com> <20220323155743.1585078-33-marcandre.lureau@redhat.com> <87o81epk1s.fsf@pond.sub.org> In-Reply-To: <87o81epk1s.fsf@pond.sub.org> From: Peter Maydell Date: Wed, 6 Apr 2022 12:14:36 +0100 Message-ID: Subject: Re: [PATCH 32/32] Remove qemu-common.h include from most units To: Markus Armbruster Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::112c; envelope-from=peter.maydell@linaro.org; helo=mail-yw1-x112c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John G Johnson , Alexey Kardashevskiy , Li Zhijian , KONRAD Frederic , "open list:raw" , Stefan Berger , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Huacai Chen , Halil Pasic , Kamil Rytarowski , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Christian Borntraeger , Michael Roth , Alexander Bulekov , Stefan Hajnoczi , John Snow , Aarushi Mehta , Kevin Wolf , Andrew Jeffery , Chris Wulff , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Subbaraya Sundeep , Zhang Chen , "open list:sPAPR \(pseries\)" , Igor Mammedov , Gerd Hoffmann , Fam Zheng , David Hildenbrand , Yanan Wang , Max Filippov , Alistair Francis , Yoshinori Sato , Helge Deller , Qiuhao Li , Artyom Tarasenko , Stefano Garzarella , Eric Farman , Corey Minyard , Stefan Weil , Julia Suvorova , Greg Kurz , Cameron Esfahani , Bandan Das , Alexander Graf , Michael Rolnik , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , "open list:RISC-V TCG CPUs" , Cornelia Huck , "open list:S390-ccw boot" , Tyrone Ting , Hanna Reitz , "open list:ARM PrimeCell and..." , Wenchao Wang , Aurelien Jarno , Elena Ufimtseva , Jason Wang , Bin Meng , Taylor Simpson , Colin Xu , "Edgar E. Iglesias" , Daniel Henrique Barboza , Joel Stanley , Aleksandar Rikalo , Mark Cave-Ayland , Fabien Chouteau , Roman Bolshakov , Sunil Muthuswamy , Eduardo Habkost , Bastian Koppelmann , Laurent Vivier , "open list:Overall KVM CPUs" , "Michael S. Tsirkin" , Christian Schoenebeck , qemu-devel@nongnu.org, "open list:X86 HAXM CPUs" , Ani Sinha , Warner Losh , Marek Vasut , Jagannathan Raman , Havard Skinnemoen , Reinoud Zandijk , Kyle Evans , marcandre.lureau@redhat.com, Richard Henderson , David Gibson , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Darren Kenny , Eric Auger , Thomas Huth , Marcelo Tosatti , Palmer Dabbelt , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 6 Apr 2022 at 11:45, Markus Armbruster wrote: > > First of all: thank you so much for completing the "empty out > qemu-common.h" job! > > This is what's left: > > #ifndef QEMU_COMMON_H > #define QEMU_COMMON_H > > /* Copyright string for -version arguments, About dialogs, etc */ > #define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \ > "Fabrice Bellard and the QEMU Project developers" > > /* Bug reporting information for --help arguments, About dialogs, etc */ > #define QEMU_HELP_BOTTOM \ > "See for how to report bugs.\n" \ > "More information on the QEMU project at ." > > #endif > Rename the header? Or replace the macros by variables, and move their > declarations elsewhere? Not demands; this series is lovely progress as > is. We should put those in a qemu/copyright.h, I think. Leaving a "qemu-common.h" around is an open invitation to people throwing more random stuff into it again in future. As you say, we can totally do this as a later followup. thanks -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2C4C433EF for ; Wed, 6 Apr 2022 14:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234984AbiDFOrP (ORCPT ); Wed, 6 Apr 2022 10:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235061AbiDFOrB (ORCPT ); Wed, 6 Apr 2022 10:47:01 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD3B4DF6C5 for ; Wed, 6 Apr 2022 04:14:48 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-2eb57fd3f56so22050297b3.8 for ; Wed, 06 Apr 2022 04:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MkKxjYAV/v0VMd11SMXqG8EhXPeJQ34GzLrs6aLHBhk=; b=BnkL/xviW3/SATQQBN0J4jLUdrTQRMmZsVp7lEWCOmkmWwekK4I3vVJpW5wY+oaW6o wMWw7poztVXO8dmLd+4dn47QCBX/MLXDvtQ0FtncjF48Ky/apTe5LetGClF9I8xv8hLd 39QIq1nCVrCyq+b89tHhY+wy8NDABlDcruy0U3VUH+wy5CC/74PQNoqlWZUGpPI4ktd2 2syhOC3nTsaeBG0iofZAEy+fKLdo2YsKyo/Wo++rIt2NrTU9fzPbBH0Ng8KlfS5PTmtk EZZmtp49FjP3cappOUQR7sHOielNZL7XjaQF+GBy228W5SABlrjalbp+fGs0YWTIyb9y NQoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MkKxjYAV/v0VMd11SMXqG8EhXPeJQ34GzLrs6aLHBhk=; b=tX5XZVuy8yoxCPwJxtIO0STFyYVLD/U8mRVpCXTblJI3U1mk8hDgDgZNaLdv5lLK1h PBe+lokRV8piKfsbn9nFjt7PBSCP4Vt1TiQZyQvAF9FJ4TMvC3Zf+98GNkH8D/hvTEdR ajIUoVe14Ad5j/FdvJz/YdyKxwvAuisfbdXbX7YvyUBkNQ0M/e6xEtk1G6qqqWU61xuy nVsbg4Fz62Ol8gYL08fy8J6N27HAfOybcy9QUXq3bgtHkH67wActFU/Bt6HIyndb437J 2wsLqFOAzPudqv4Apl7lozbD3f3aWhOBSqzm74FojAQ90cwXeZDedRNhDDV46O524r4o SDvg== X-Gm-Message-State: AOAM532t+vO73juUltpK95HZt2X/Ckuu8mVW49hbsVZFUiPlawYjHa6q PiGfho6bQktV3YnpUJckkIgr6mLJyceK536TgzZR3Q== X-Google-Smtp-Source: ABdhPJytWaKSjrcKoa2mbzwJv7RhwFSgw11lPqUjgtEaNT3OmaJMCRA7mDMdyjLwii6p/gHggvStzLZXxV0l/YkXcmI= X-Received: by 2002:a81:1592:0:b0:2eb:5472:c681 with SMTP id 140-20020a811592000000b002eb5472c681mr6491648ywv.10.1649243687745; Wed, 06 Apr 2022 04:14:47 -0700 (PDT) MIME-Version: 1.0 References: <20220323155743.1585078-1-marcandre.lureau@redhat.com> <20220323155743.1585078-33-marcandre.lureau@redhat.com> <87o81epk1s.fsf@pond.sub.org> In-Reply-To: <87o81epk1s.fsf@pond.sub.org> From: Peter Maydell Date: Wed, 6 Apr 2022 12:14:36 +0100 Message-ID: Subject: Re: [PATCH 32/32] Remove qemu-common.h include from most units To: Markus Armbruster Cc: Ani Sinha , marcandre.lureau@redhat.com, Aarushi Mehta , Aleksandar Rikalo , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Alexander Bulekov , Alexander Graf , Alexey Kardashevskiy , Alistair Francis , Andrew Jeffery , Artyom Tarasenko , Aurelien Jarno , BALATON Zoltan , Bandan Das , Bastian Koppelmann , Bin Meng , Cameron Esfahani , Chris Wulff , Christian Borntraeger , Christian Schoenebeck , Colin Xu , Corey Minyard , Cornelia Huck , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Daniel Henrique Barboza , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Darren Kenny , David Gibson , David Hildenbrand , "Edgar E. Iglesias" , Eduardo Habkost , Elena Ufimtseva , Eric Auger , Eric Farman , Fabien Chouteau , Fam Zheng , Gerd Hoffmann , Greg Kurz , Halil Pasic , Hanna Reitz , Havard Skinnemoen , Helge Deller , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Huacai Chen , Igor Mammedov , Jagannathan Raman , Jason Wang , Jiaxun Yang , Joel Stanley , John G Johnson , John Snow , Julia Suvorova , KONRAD Frederic , Kamil Rytarowski , Kevin Wolf , Kyle Evans , Laurent Vivier , Li Zhijian , Marcel Apfelbaum , Marcelo Tosatti , Marek Vasut , Mark Cave-Ayland , Max Filippov , Michael Rolnik , Michael Roth , "Michael S. Tsirkin" , Palmer Dabbelt , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Qiuhao Li , Reinoud Zandijk , Richard Henderson , Roman Bolshakov , Stefan Berger , Stefan Hajnoczi , Stefan Weil , Stefano Garzarella , Subbaraya Sundeep , Sunil Muthuswamy , Taylor Simpson , Thomas Huth , Tyrone Ting , Warner Losh , Wenchao Wang , Yanan Wang , Yoshinori Sato , Zhang Chen , "open list:ARM PrimeCell and..." , "open list:Overall KVM CPUs" , "open list:RISC-V TCG CPUs" , "open list:S390-ccw boot" , "open list:X86 HAXM CPUs" , "open list:raw" , "open list:sPAPR (pseries)" , qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 6 Apr 2022 at 11:45, Markus Armbruster wrote: > > First of all: thank you so much for completing the "empty out > qemu-common.h" job! > > This is what's left: > > #ifndef QEMU_COMMON_H > #define QEMU_COMMON_H > > /* Copyright string for -version arguments, About dialogs, etc */ > #define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \ > "Fabrice Bellard and the QEMU Project developers" > > /* Bug reporting information for --help arguments, About dialogs, etc */ > #define QEMU_HELP_BOTTOM \ > "See for how to report bugs.\n" \ > "More information on the QEMU project at ." > > #endif > Rename the header? Or replace the macros by variables, and move their > declarations elsewhere? Not demands; this series is lovely progress as > is. We should put those in a qemu/copyright.h, I think. Leaving a "qemu-common.h" around is an open invitation to people throwing more random stuff into it again in future. As you say, we can totally do this as a later followup. thanks -- PMM