From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VrA6l-0005rh-SB
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 12:31:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VrA6g-0001kE-HT
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 12:31:31 -0500
Received: from mail-pb0-f42.google.com ([209.85.160.42]:36337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1VrA6g-0001jJ-CE
	for qemu-devel@nongnu.org; Thu, 12 Dec 2013 12:31:26 -0500
Received: by mail-pb0-f42.google.com with SMTP id uo5so902441pbc.15
	for <qemu-devel@nongnu.org>; Thu, 12 Dec 2013 09:31:25 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1386279359-32286-3-git-send-email-roy.franz@linaro.org>
References: <1386279359-32286-1-git-send-email-roy.franz@linaro.org>
	<1386279359-32286-3-git-send-email-roy.franz@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 12 Dec 2013 17:31:05 +0000
Message-ID: <CAFEAcA9mEJ2HQB1SidAjFHq9OLY0m15Y2YMpw+sKf3e3eAi6Bg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH V5 2/7] Add device-width property to
	pflash_cfi01
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roy Franz <roy.franz@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Patch Tracking <patches@linaro.org>

On 5 December 2013 21:35, Roy Franz <roy.franz@linaro.org> wrote:
> The width of the devices that make up the flash interface
> is required to mask certain commands, in particular the
> write length for buffered writes.  This length will be presented
> to each device on the interface by the program writing the flash,
> and the flash emulation code needs to be able to determine
> the length of the write as recieved by each flash device.
> The device-width defaults to the bank width which should
> maintain existing behavior for platforms that don't need
> this change.
> This change is required to support buffered writes on the
> vexpress platform that has a 32 bit flash interface with 2
> 16 bit devices on it.
>
> Signed-off-by: Roy Franz <roy.franz@linaro.org

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM