From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org,
owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com,
gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com,
knoel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/6] rdma: core logic
Date: Fri, 28 Jun 2013 14:28:40 +0100 [thread overview]
Message-ID: <CAFEAcA9nV_i6bHM_nzvYRHk4uoq9RQwp4+kooCCUrrVxnbuHWw@mail.gmail.com> (raw)
In-Reply-To: <51CD8E44.2090201@linux.vnet.ibm.com>
On 28 June 2013 14:23, Michael R. Hines <mrhines@linux.vnet.ibm.com> wrote:
>> I assume from the PACKED annotations (do we really need both,
>> incidentally) that this is shared with either the guest or
>> with another instance of QEMU. Are there definitely no
>> endianness issues to deal with here?
>
>
> I have ntohl()/htonl() on the protocol headers, but I did not
> add them for the data portions of the protocol.
>
>
> Is endianess for the data a big issue when you are assume the migration
> is happening across identical CPU architectures?
Well:
* is that a reasonable assumption? (why?)
* if you try this on some setup where it's not true, do we
fail helpfully or obscurely?
This is really just my usual "all the world is not an x86"
nudge; I don't know enough about rdma to be able to say what
the right thing in this particular case is.
-- PMM
next prev parent reply other threads:[~2013-06-28 13:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 22:44 [Qemu-devel] [PATCH 0/6] rdma: core logic and unpin support mrhines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 1/6] rdma: update documentation to reflect new " mrhines
2013-06-27 23:09 ` Eric Blake
2013-06-28 13:17 ` Michael R. Hines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 2/6] rdma: introduce ram_handle_compressed() mrhines
2013-06-27 22:56 ` Peter Maydell
2013-06-28 7:17 ` Paolo Bonzini
2013-06-27 22:44 ` [Qemu-devel] [PATCH 3/6] rdma: core logic mrhines
2013-06-27 23:16 ` Peter Maydell
2013-06-28 13:23 ` Michael R. Hines
2013-06-28 13:28 ` Peter Maydell [this message]
2013-06-28 14:00 ` Michael R. Hines
2013-06-28 14:07 ` Peter Maydell
2013-06-28 14:22 ` Michael R. Hines
2013-06-28 7:33 ` Paolo Bonzini
2013-06-28 14:11 ` Michael R. Hines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 4/6] rdma: allow state transitions between other states besides ACTIVE mrhines
2013-06-27 23:10 ` Eric Blake
2013-06-28 7:34 ` Paolo Bonzini
2013-06-27 22:44 ` [Qemu-devel] [PATCH 5/6] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition mrhines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 6/6] rdma: account for the time spent in MIG_STATE_SETUP through QMP mrhines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9nV_i6bHM_nzvYRHk4uoq9RQwp4+kooCCUrrVxnbuHWw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=chegu_vinod@hp.com \
--cc=gokul@us.ibm.com \
--cc=knoel@redhat.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.