All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Christopher Friedt <chrisfriedt@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Fam Zheng <famz@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.
Date: Wed, 4 May 2016 10:03:12 +0100	[thread overview]
Message-ID: <CAFEAcA9ob9RZ55Hhh+DwAFt92V0oNL+57rDmFk6GGaPkxdAqtw@mail.gmail.com> (raw)
In-Reply-To: <CAF4BF-Re+siJV4KTOvUwsDS3ckt_HfPpCQkB7rPPmJZ=OS8tSw@mail.gmail.com>

On 4 May 2016 at 01:07, Christopher Friedt <chrisfriedt@gmail.com> wrote:
>
> On May 3, 2016 9:50 AM, "Christopher Friedt" <chrisfriedt@gmail.com> wrote:
>>
>> On Tue, May 3, 2016 at 3:06 AM, Richard Henderson <rth@twiddle.net> wrote:
>> > On 05/02/2016 03:10 PM, Christopher Friedt wrote:
>> >>
>> >>  %.a:
>> >> +ifdef CONFIG_DARWIN
>> >> +       $(call quiet-command,rm -f $@ && libtool -static -o $@ $^,"
>> >> libtool    $(TARGET_DIR)$@")
>> >> +else
>> >>         $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,"  AR
>> >> $(TARGET_DIR)$@")
>> >> +endif
>> >>
>> >
>> > Does it work to use libtool -static everywhere?
>
> One possibility for future-proofing the link stage that applies to most
> (all?) platforms that Qemu runs on would be to switch to libtool for all
> arch's and just adjust the "libtool flags" as necessary.
>
> Would require checking for libtool.

This is more complicated than we need. OSX "libtool" and GNU
"libtool" are really completely different things. We don't
(these days) do anything that we need GNU libtool for, so
there's no need to depend on it or use it optionally -- we should
just use "ar". If we need to special case the "program for creating
static libraries" for OSX that's annoying but we can do that.

thanks
-- PMM

  reply	other threads:[~2016-05-04  9:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  1:10 [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin Christopher Friedt
2016-05-03  7:06 ` Richard Henderson
2016-05-03 13:50   ` Christopher Friedt
2016-05-03 14:12     ` Peter Maydell
2016-05-04  0:07     ` Christopher Friedt
2016-05-04  9:03       ` Peter Maydell [this message]
2016-09-14  7:30 ` Michael Tokarev
2016-09-20 17:58   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA9ob9RZ55Hhh+DwAFt92V0oNL+57rDmFk6GGaPkxdAqtw@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=chrisfriedt@gmail.com \
    --cc=famz@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.