All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [Qemu-arm] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none"
Date: Tue, 17 Apr 2018 13:52:38 +0100	[thread overview]
Message-ID: <CAFEAcA9pTyF=xHz_2Dt3XqQrUnKrPthFP+zpjV8ba2PVM-s7iw@mail.gmail.com> (raw)
In-Reply-To: <87in8qf2w3.fsf@dusky.pond.sub.org>

On 17 April 2018 at 13:12, Markus Armbruster <armbru@redhat.com> wrote:
> Thomas Huth <thuth@redhat.com> writes:
>>  In case someone wants to help with creating some bug fix patches
>>  during the QEMU hard freeze phase: This test can now be used to
>>  trigger lots of introspection bugs that we were not aware of yet.
>>  I think most of the bugs are due to wrong handling of instance_init
>>  vs. realize functions.
>
> Yes, that's a common class of bugs.  There's little guidance on what
> kind of work belongs where, and plenty of bad examples.  Some of the bad
> examples crash (as you found).  Some work fine, typically because the
> device doesn't support unplug.

I've been vaguely wondering if we should start to recommend that
all devices have a correctly implemented code path for destroying
them post-realize, even if they don't actually implement hotplug...

thanks
-- PMM

  reply	other threads:[~2018-04-17 12:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19  9:39 [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none" Thomas Huth
2018-03-19 20:37 ` Eduardo Habkost
2018-04-17 12:12 ` Markus Armbruster
2018-04-17 12:52   ` Peter Maydell [this message]
2018-04-17 13:15     ` [Qemu-devel] [Qemu-arm] " Markus Armbruster
2018-04-26 10:24   ` [Qemu-devel] " Thomas Huth
2018-04-26 11:54     ` Markus Armbruster
2018-04-26 15:27       ` Thomas Huth
2018-04-27  0:34       ` Eduardo Habkost
2018-04-27  3:45         ` Thomas Huth
2018-04-27  6:06       ` [Qemu-devel] qom-test (was: [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none") Thomas Huth
2018-04-27  6:29         ` [Qemu-devel] qom-test Markus Armbruster
2018-04-27 10:20         ` [Qemu-devel] [Qemu-arm] qom-test (was: [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none") Peter Maydell
2018-04-27 10:24           ` [Qemu-devel] [Qemu-arm] qom-test Thomas Huth
2018-04-27 16:30             ` Markus Armbruster
2018-04-27 16:36               ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2018-04-26 11:45 ` [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none" Markus Armbruster
2018-04-26 15:20   ` Thomas Huth
2018-04-27  0:32     ` Eduardo Habkost
2018-04-27  3:52       ` Thomas Huth
2018-04-27  6:31       ` Markus Armbruster
2018-04-27  7:31         ` Thomas Huth
2018-04-27  8:05           ` Markus Armbruster
2018-05-07 13:53         ` Eduardo Habkost
2018-05-07 16:50           ` Markus Armbruster
2018-05-07 17:02             ` Thomas Huth
2018-05-07 17:04             ` [Qemu-devel] [Qemu-arm] " Peter Maydell
2018-05-07 18:21             ` [Qemu-devel] " Eduardo Habkost
2018-05-07 19:13               ` Thomas Huth
2018-05-07 19:32                 ` Eduardo Habkost
2018-05-08  5:33                   ` [Qemu-devel] Running QEMU without default devices / kernel / bios (was: Test devices with all machines, not only with "none") Thomas Huth
2018-05-08 10:47                     ` [Qemu-devel] Running QEMU without default devices / kernel / bios Thomas Huth
2018-05-08 16:40                     ` [Qemu-devel] Running QEMU without default devices / kernel / bios (was: Test devices with all machines, not only with "none") Eduardo Habkost
2018-05-09  7:41                       ` [Qemu-devel] [Qemu-ppc] Running QEMU without default devices / kernel / bios Thomas Huth
2018-05-09 11:36                         ` Markus Armbruster
2018-05-08  5:41                   ` [Qemu-devel] [RFC PATCH] tests/device-introspect: Test devices with all machines, not only with "none" Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA9pTyF=xHz_2Dt3XqQrUnKrPthFP+zpjV8ba2PVM-s7iw@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.