From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Maydell Subject: Re: [PATCH v9 6/6] tests/guest-debug: introduce basic gdbstub tests Date: Fri, 20 Nov 2015 16:17:19 +0000 Message-ID: References: <1447345251-22625-1-git-send-email-alex.bennee@linaro.org> <1447345251-22625-7-git-send-email-alex.bennee@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: QEMU Developers , qemu-arm@nongnu.org, Christoffer Dall , Zhichao Huang , kvm-devel , arm-mail-list , "kvmarm@lists.cs.columbia.edu" , Marc Zyngier , =?UTF-8?B?QWxleCBCZW5uw6ll?= To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Return-path: Received: from mail-vk0-f45.google.com ([209.85.213.45]:34831 "EHLO mail-vk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758951AbbKTQRl convert rfc822-to-8bit (ORCPT ); Fri, 20 Nov 2015 11:17:41 -0500 Received: by vkha189 with SMTP id a189so611966vkh.2 for ; Fri, 20 Nov 2015 08:17:39 -0800 (PST) In-Reply-To: <1447345251-22625-7-git-send-email-alex.bennee@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: On 12 November 2015 at 16:20, Alex Benn=C3=A9e = wrote: > From: Alex Benn=C3=A9e > > The aim of these tests is to combine with an appropriate kernel > image (with symbol-file vmlinux) and check it behaves as it should. > Given a kernel it checks: > > - single step > - software breakpoint > - hardware breakpoint > - access, read and write watchpoints > > On success it returns 0 to the calling process. > > I've not plumbed this into the "make check" logic though as we need a > solution for providing non-host binaries to the tests. However the te= st > is structured to work with pretty much any Linux kernel image as it > uses the basic kernel_init code which is common across architectures. Do these tests pass if you run them on the TCG QEMU, just out of interest? I'm not a great fan of tests that aren't in 'make check' because IME they just bitrot, but as you say we have no sensible approach for handling tests that need to run real guest code :-( thanks -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzoNY-0000Mi-Ph for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:17:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzoNX-0006OG-QV for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:17:40 -0500 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]:34203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzoNX-0006OA-N2 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 11:17:39 -0500 Received: by vkbs1 with SMTP id s1so614437vkb.1 for ; Fri, 20 Nov 2015 08:17:39 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1447345251-22625-7-git-send-email-alex.bennee@linaro.org> References: <1447345251-22625-1-git-send-email-alex.bennee@linaro.org> <1447345251-22625-7-git-send-email-alex.bennee@linaro.org> From: Peter Maydell Date: Fri, 20 Nov 2015 16:17:19 +0000 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v9 6/6] tests/guest-debug: introduce basic gdbstub tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: =?UTF-8?B?QWxleCBCZW5uw6ll?= , kvm-devel , Marc Zyngier , QEMU Developers , qemu-arm@nongnu.org, Christoffer Dall , Zhichao Huang , "kvmarm@lists.cs.columbia.edu" , arm-mail-list On 12 November 2015 at 16:20, Alex Benn=C3=A9e wro= te: > From: Alex Benn=C3=A9e > > The aim of these tests is to combine with an appropriate kernel > image (with symbol-file vmlinux) and check it behaves as it should. > Given a kernel it checks: > > - single step > - software breakpoint > - hardware breakpoint > - access, read and write watchpoints > > On success it returns 0 to the calling process. > > I've not plumbed this into the "make check" logic though as we need a > solution for providing non-host binaries to the tests. However the test > is structured to work with pretty much any Linux kernel image as it > uses the basic kernel_init code which is common across architectures. Do these tests pass if you run them on the TCG QEMU, just out of interest? I'm not a great fan of tests that aren't in 'make check' because IME they just bitrot, but as you say we have no sensible approach for handling tests that need to run real guest code :-( thanks -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.maydell@linaro.org (Peter Maydell) Date: Fri, 20 Nov 2015 16:17:19 +0000 Subject: [PATCH v9 6/6] tests/guest-debug: introduce basic gdbstub tests In-Reply-To: <1447345251-22625-7-git-send-email-alex.bennee@linaro.org> References: <1447345251-22625-1-git-send-email-alex.bennee@linaro.org> <1447345251-22625-7-git-send-email-alex.bennee@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12 November 2015 at 16:20, Alex Benn?e wrote: > From: Alex Benn?e > > The aim of these tests is to combine with an appropriate kernel > image (with symbol-file vmlinux) and check it behaves as it should. > Given a kernel it checks: > > - single step > - software breakpoint > - hardware breakpoint > - access, read and write watchpoints > > On success it returns 0 to the calling process. > > I've not plumbed this into the "make check" logic though as we need a > solution for providing non-host binaries to the tests. However the test > is structured to work with pretty much any Linux kernel image as it > uses the basic kernel_init code which is common across architectures. Do these tests pass if you run them on the TCG QEMU, just out of interest? I'm not a great fan of tests that aren't in 'make check' because IME they just bitrot, but as you say we have no sensible approach for handling tests that need to run real guest code :-( thanks -- PMM