Re: [PATCH 1/2 v3] Configure script for Haiku

From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Zak <richard.j.zak@gmail.com>
Cc: Thomas Huth <thuth@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/2 v3] Configure script for Haiku
Date: Sun, 4 Jul 2021 18:10:54 +0100	[thread overview]
Message-ID: <CAFEAcA9rAAuzCh3MVSnfrBWZSvHVrmMqgqJ8OX0=nQKDXoVPpg@mail.gmail.com> (raw)
In-Reply-To: <CAOakUfO=C+pgcwopdTCrsH3vtFuFWo8QQBU8kEjnE=_3q-mMYg@mail.gmail.com>

On Sun, 4 Jul 2021 at 17:44, Richard Zak <richard.j.zak@gmail.com> wrote:
>
> Use system capstone, for which a port is maintained by Haiku. Disable TPM which isn't supported.
>
> Signed-off-by: Richard Zak <richard.j.zak@gmail.com>
> ---
>  configure | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index e799d908a3..c928071f69 100755
> --- a/configure
> +++ b/configure
> @@ -358,6 +358,7 @@ oss_lib=""
>  bsd="no"
>  linux="no"
>  solaris="no"
> +haiku="no"
>  profiler="no"
>  cocoa="auto"
>  softmmu="yes"
> @@ -769,6 +770,8 @@ SunOS)
>  ;;
>  Haiku)
>    haiku="yes"
> +  tpm="no"

If the autodetect for tpm doesn't get this right, we should fix
the autodetect.

As a general principle we prefer to avoid "do this specific thing
for this specific host OS" whenever we can, in favour of "test
whether we have whatever feature/function/library is required".

thanks
-- PMM