From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlLQw-0002cq-Lr for qemu-devel@nongnu.org; Thu, 23 Apr 2015 14:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlLQr-0005tC-3m for qemu-devel@nongnu.org; Thu, 23 Apr 2015 14:01:06 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:35333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlLQq-0005t8-Ue for qemu-devel@nongnu.org; Thu, 23 Apr 2015 14:01:01 -0400 Received: by iejt8 with SMTP id t8so66770497iej.2 for ; Thu, 23 Apr 2015 11:01:00 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4aa1fe1f66ef0765564e50b26a64bdf2427ac7cd.1427108387.git.peter.crosthwaite@xilinx.com> References: <4aa1fe1f66ef0765564e50b26a64bdf2427ac7cd.1427108387.git.peter.crosthwaite@xilinx.com> From: Peter Maydell Date: Thu, 23 Apr 2015 19:00:40 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH target-arm v4 11/16] char: cadence_uart: Split state struct and type into header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Edgar Iglesias , zach.pfeffer@xilinx.com, Ryota Ozaki , QEMU Developers , Alistair Francis , michals@xilinx.com On 23 March 2015 at 11:05, Peter Crosthwaite wrote: > To allow using the device with modern SoC programming conventions. The > state struct needs to be visible to embed the device in SoC containers. > > Reviewed-by: Alistair Francis > Signed-off-by: Peter Crosthwaite Non-standalone commit message body, header file needs copyright/license comment, include guard shouldn't have trailing _. Otherwise: Reviewed-by: Peter Maydell thanks -- PMM