From: Peter Maydell <peter.maydell@linaro.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv
Date: Thu, 1 May 2014 19:08:29 +0100 [thread overview]
Message-ID: <CAFEAcA9v_BycpH2nVYgv39n5+Ka+LchAjG-CzgasfDhc3PNUGQ@mail.gmail.com> (raw)
In-Reply-To: <1395789710-29191-1-git-send-email-james.hogan@imgtec.com>
Ping!
Riku -- do you have this in your tree now?
(I'm adding an aux entry for AT_HWCAP2 and I noticed the
assert wasn't firing :-))
thanks
-- PMM
On 25 March 2014 23:21, James Hogan <james.hogan@imgtec.com> wrote:
> Assert that the amount of stack space used for auxvec, envp & argv
> exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
> updated when another NEW_AUX_ENT is added.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
> This should be applied after "linux-user: Correct DLINFO_ITEMS" or the
> assert will fail.
>
> Tested with linux-user-test-0.3 before and after fixing DLINFO_ITEMS.
> ---
> linux-user/elfload.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index d2380b6..ecf6f35 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -1455,6 +1455,8 @@ static abi_ulong create_elf_tables(abi_ulong p, int argc, int envc,
> info->auxv_len = sp_auxv - sp;
>
> sp = loader_build_argptr(envc, argc, sp, p, 0);
> + /* Check the right amount of stack was allocated for auxvec, envp & argv. */
> + assert(sp_auxv - sp == size);
> return sp;
> }
>
> --
> 1.8.3.2
>
next prev parent reply other threads:[~2014-05-01 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 23:21 [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv James Hogan
2014-05-01 18:08 ` Peter Maydell [this message]
2014-05-02 10:03 ` Riku Voipio
2014-05-02 10:07 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA9v_BycpH2nVYgv39n5+Ka+LchAjG-CzgasfDhc3PNUGQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=james.hogan@imgtec.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.