From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YhxKO-0000VS-Pb
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 05:40:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YhxBG-0005aN-SV
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 05:31:57 -0400
Received: from mail-ig0-f182.google.com ([209.85.213.182]:36148)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1YhxBG-0005aJ-OD
	for qemu-devel@nongnu.org; Tue, 14 Apr 2015 05:30:54 -0400
Received: by igblo3 with SMTP id lo3so68881544igb.1
	for <qemu-devel@nongnu.org>; Tue, 14 Apr 2015 02:30:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <552C691D.3090702@huawei.com>
References: <1428055432-12120-1-git-send-email-zhaoshenglong@huawei.com>
	<1428055432-12120-20-git-send-email-zhaoshenglong@huawei.com>
	<87mw2cj9zi.fsf@linaro.org> <552C691D.3090702@huawei.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Tue, 14 Apr 2015 10:30:34 +0100
Message-ID: <CAFEAcA9wjjCCBVzAJuB945qKQXsShKn-Lu4R8ExYKg1Ga3-j2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe
 controller in ACPI DSDT table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: hangaohuai@huawei.com, "Michael S. Tsirkin" <mst@redhat.com>, Alexander Spyridakis <a.spyridakis@virtualopensystems.com>, Mark Salter <msalter@redhat.com>, Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>, Laszlo Ersek <lersek@redhat.com>, Hanjun Guo <hanjun.guo@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Shannon Zhao <shannon.zhao@linaro.org>

On 14 April 2015 at 02:10, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> On 2015/4/13 23:58, Alex Benn=C3=A9e wrote:
>>
>> Shannon Zhao <zhaoshenglong@huawei.com> writes:
>>> +    UUID =3D aml_touuid(0x33DB4D5B, 0x1FF7, 0x401C, 0x9657,
>>> 0x7441C03DD766);
>>
>> This looks like a fairly unreadable uuid already. What are these magic n=
umbers?
>>
>
> Yes, this will be modified to use string according to the spec. Like belo=
w way:
>
> UUID =3D aml_touuid("33DB4D5B-1FF7-401C-9657-7441C03DD766");

Those are still magic numbers, you've  just put them into
a different format. Where do they come from? What do they mean?

-- PMM